]> source.dussan.org Git - poi.git/commit
Function PROPER: Don't use a regular expression syntax that is not available on Andro...
authorDominik Stadler <centic@apache.org>
Fri, 15 Jul 2016 06:32:45 +0000 (06:32 +0000)
committerDominik Stadler <centic@apache.org>
Fri, 15 Jul 2016 06:32:45 +0000 (06:32 +0000)
commitaec95a44918e5331f0d3a746202c713bc8ac6aad
treee4769f144ed67cf792840a27c6e447926fea2ca1
parent75f5d3afc54d39299a0d4419ad7c470d995a4520
Function PROPER: Don't use a regular expression syntax that is not available on Android. Actually the use of regular expression in this case was overkill, slow and even incorrect in corner cases, the function can be done without regex easily and runs a bit faster anyway (microBench is down from 4sec to 2s)
Also added a unit-test to ensure the behavior stays the same (except in cases where it needed fixing, e.g. some toUppercase() leads to more than one character which was handled incorrectly)

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1752779 13f79535-47bb-0310-9956-ffa450edef68
src/java/org/apache/poi/ss/formula/functions/TextFunction.java
src/testcases/org/apache/poi/ss/formula/functions/TestProper.java [new file with mode: 0644]