]> source.dussan.org Git - nextcloud-server.git/commit
Show loading spinner until share settings are fully loaded 38163/head
authorDaniel Calviño Sánchez <danxuliu@gmail.com>
Tue, 9 May 2023 16:11:58 +0000 (18:11 +0200)
committerDaniel Calviño Sánchez <danxuliu@gmail.com>
Wed, 10 May 2023 01:00:37 +0000 (03:00 +0200)
commitb677d3e27d626a09a49794f0c3e41e9c75fcd8c7
tree6b1aa7e8fb47a4b063cdd98c98c784d34d98db60
parentfc076271c791998272856b640be4b63cfe3263a2
Show loading spinner until share settings are fully loaded

The inputs of the sharing settings are generated in a template in the
server, but the listeners to react to changes in the elements and save
the values in the server are loaded in the client once the DOM finishes
loading. If the DOM takes long to load the user can start to interact
with the settings before the listeners were set up and, therefore, the
changes would not be saved in the server. However, as the inputs are
modified the user would think that the changes were already saved.

To address that now when the sharing settings are open a loading spinner
is shown instead of the contents of the sharing settings, and only once
the listeners to save the changes were set up the spinner is removed and
the contents shown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
apps/settings/css/settings.css
apps/settings/css/settings.css.map
apps/settings/css/settings.scss
apps/settings/src/admin.js
apps/settings/templates/settings/admin/sharing.php
dist/settings-legacy-admin.js
dist/settings-legacy-admin.js.map