]> source.dussan.org Git - gitea.git/commit
Correctly handle failed migrations (#17575)
authorzeripath <art27@cantab.net>
Sat, 13 Nov 2021 11:28:50 +0000 (11:28 +0000)
committerGitHub <noreply@github.com>
Sat, 13 Nov 2021 11:28:50 +0000 (19:28 +0800)
commitbab95c3a86f63f521311a77e516be5b6c521e0a4
tree2b77de81f4985b5f899c8769cfa1616dbf4285f7
parent47448083a1b88201dcfa00ec06fb748f5ac18040
Correctly handle failed migrations (#17575)

* Correctly handle failed migrations

There is a bug in handling failed migrations whereby the migration task gets decoupled
from the migration repository. This leads to a failure of the task to get deleted with
the repository and also leads to the migration failed page resulting in a ISE.

This PR removes the zeroing out of the task id from the migration but also makes
the migration handler tolerate missing tasks much nicer.

Fix #17571

Signed-off-by: Andrew Thornton <art27@cantab.net>
modules/task/migrate.go
modules/task/task.go
options/locale/locale_en-US.ini
routers/web/repo/view.go
routers/web/user/task.go
templates/repo/migrate/migrating.tmpl