]> source.dussan.org Git - nextcloud-server.git/commit
fix: Fix unmodified placeholder replacing the actual value when updating
authorDaniel Calviño Sánchez <danxuliu@gmail.com>
Tue, 30 Jul 2024 01:05:27 +0000 (03:05 +0200)
committerskjnldsv <skjnldsv@protonmail.com>
Wed, 4 Sep 2024 07:46:17 +0000 (09:46 +0200)
commitbd4de5208d6e8fb052f9b36f0a3b2f2d66c7c8cd
treeec97e97248d18a12ce16aa1187d6e416d208f301
parent8350aef72310160f8ab3b0798befb89acaad1874
fix: Fix unmodified placeholder replacing the actual value when updating

When updating global storages and user storages a property is not
updated by "StoragesService::updateStorage()" if the value matches the
unmodified placeholder. However, userglobal storages are not updated
through the "StoragesService"; as only the authentication mechanism is
updated it is directly done with "saveBackendOptions()" in
"IUserProvided" or "UserGlobalAuth". Due to this the unmodified
placeholder value needs to be explicitly checked in those cases and
replaced by the actual value (note that in this case it is not possible
to just skip updating a specific property).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
apps/files_external/lib/Lib/Auth/Password/UserGlobalAuth.php
apps/files_external/lib/Lib/Auth/Password/UserProvided.php
build/integration/files_features/external-storage.feature