]> source.dussan.org Git - jgit.git/commit
FS: Fix lazy initialization of non-volatile static field 10/83410/2
authorDavid Pursehouse <david.pursehouse@gmail.com>
Tue, 18 Oct 2016 04:51:27 +0000 (13:51 +0900)
committerDavid Pursehouse <david.pursehouse@gmail.com>
Tue, 18 Oct 2016 05:15:53 +0000 (14:15 +0900)
commitbdf3e43d7652e8fbfbf3416d8b8df1c6dbddbc14
tree3021ab8ef1088d6521dc1db712f142041055fb11
parente9107e853f290677eab844ac8d09db0891bdd20e
FS: Fix lazy initialization of non-volatile static field

The 'factory' field is lazy initialized in the detect() method.

According to FindBugs:

   Because the compiler or processor may reorder instructions, threads
   are not guaranteed to see a completely initialized object, if the
   method can be called by multiple threads.

Fix this by declaring the member as 'volatile'.

Change-Id: Ib32663bb28c9564584256e01f625b4e7875e6223
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
org.eclipse.jgit/src/org/eclipse/jgit/util/FS.java