]> source.dussan.org Git - nextcloud-server.git/commit
Fix comparison of PHP versions 25138/head
authorDamien Goutte-Gattat <dgouttegattat@incenp.org>
Thu, 14 Jan 2021 22:54:53 +0000 (22:54 +0000)
committerDamien Goutte-Gattat <dgouttegattat@incenp.org>
Thu, 14 Jan 2021 23:03:20 +0000 (23:03 +0000)
commitbedd9acf7874b836bef224989c2ce7f5e3b0a2fa
tree19b15fdb4fd7878cef9f5f77a7b90981b6f18d2b
parentceb3a0090ed1f9f94312097519ee10d42a4a3811
Fix comparison of PHP versions

Use the builtin function `version_compare` to check an app's
compatibility with the available PHP version, instead of reusing
the `OC\App\CompareVersion::isCompatible` method which is intended
to compare Nextcloud versions. PHP version strings do not always
necessarily follow the simple Major.Minor.Patch format used by
Nextcloud and therefore cannot be properly compared by that method.

Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>
lib/private/App/AppStore/Fetcher/AppFetcher.php