]> source.dussan.org Git - jgit.git/commit
CommitGraphWriter: Unnest generation-number progress 39/205339/2
authorIvan Frade <ifrade@google.com>
Tue, 7 Nov 2023 19:36:51 +0000 (11:36 -0800)
committerIvan Frade <ifrade@google.com>
Tue, 7 Nov 2023 21:41:54 +0000 (13:41 -0800)
commitc46b54eeac1cb2aaf62d4394fb7f60c848eab7b1
treea603b5fd1a4813d7707f86e2c2a97cbf37e5f748
parent3937300f3eb4dd557ec2d195f21793f737d6cb4e
CommitGraphWriter: Unnest generation-number progress

The ProgressMonitor task to track the calculation of generation
numbers is nested inside the task that follows the writing of all
lines in the commit-graph. ProgressMonitor doesn't support nested
tasks and this confuses the counting.

Move the start/end of the "writing commit graph" task to the
writeCommitData section, after calculating the generation
numbers. Make that task track by commits instead of by lines.

Moving the start/end of the progress task to the chunk-writing
functions is clearer and easier to extend.

Logging of GC before:
Writing out commit-graph in 3 passes:  51% ( 9807/19358)
Computing commit-graph generation numbers: 100% (9551/9551)

Logging of GC after:
Computing commit-graph generation numbers: 100% (9551/9551)
Writing out commit-graph: 100% (9551/9551)

Change-Id: I87d69c06c9a3c7e75be12b6f0d1a63b5924e298a
org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriterTest.java
org.eclipse.jgit/resources/org/eclipse/jgit/internal/JGitText.properties
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriter.java