]> source.dussan.org Git - gitblit.git/commit
Use Guice-Servlet rather than custom code and expose the Injector
authorJames Moger <james.moger@gitblit.com>
Fri, 23 May 2014 12:17:11 +0000 (08:17 -0400)
committerJames Moger <james.moger@gitblit.com>
Thu, 3 Jul 2014 20:57:47 +0000 (16:57 -0400)
commitc828cf2db88956094a31a79741145688876879df
tree7f9d7e8b0fe7d91350afb79b2baf60f543712150
parentaa1361d04cfe09f90e7d8bece90c00dd6e4185bb
Use Guice-Servlet rather than custom code and expose the Injector

This is a fairly functional variation of Gitblit with one notable
exception:

    The security filters are not working properly.

This is a design flaw in Guice that I have reported upstream [1].  The
general idea is that Guice-Servlet filters are not properly wrapping the
ServletRequest. This has historically been a problem for Guice-Servlet
servlets but Google has fixed most of those issues.  Unfortunately, all
the same flaws reported against the servlet delegation also exist in
Guice-Servlet filter delegation. :(

[1]: https://code.google.com/p/google-guice/issues/detail?id=807
15 files changed:
.classpath
build.moxie
gitblit.iml
src/main/java/WEB-INF/web.xml
src/main/java/com/gitblit/guice/CoreModule.java [new file with mode: 0644]
src/main/java/com/gitblit/guice/GuiceContext.java [deleted file]
src/main/java/com/gitblit/guice/GuiceModule.java [deleted file]
src/main/java/com/gitblit/guice/WebModule.java [new file with mode: 0644]
src/main/java/com/gitblit/manager/GitblitManager.java
src/main/java/com/gitblit/manager/IRuntimeManager.java
src/main/java/com/gitblit/manager/RuntimeManager.java
src/main/java/com/gitblit/servlet/AuthenticationFilter.java
src/main/java/com/gitblit/servlet/GitblitContext.java
src/main/java/com/gitblit/servlet/InjectionContextListener.java [deleted file]
src/test/java/com/gitblit/tests/mock/MockRuntimeManager.java