]> source.dussan.org Git - jgit.git/commit
Remove unnecessary argument handler in MergeBase.java 96/1201696/1
authorKamil Musin <kamilm@google.com>
Tue, 8 Oct 2024 11:25:53 +0000 (13:25 +0200)
committerKamil Musin <kamilm@google.com>
Tue, 8 Oct 2024 12:27:22 +0000 (14:27 +0200)
commitc99c8b9d00063fd177e4e895ac3e155cd2a0b437
tree469518c110038fd345682f9153910a4fd1f910e8
parentdd8c3dab8af85a4c367949c06c648d1e6c9a9f4a
Remove unnecessary argument handler in MergeBase.java

Currently the parsing of command line arguments always results in an
error.

```
fatal: Argument "commit-ish" is required
```

This is caused by the fact that the first method (commit_0) is invoked
twice. (As if the multiValued = true). I couldn't figure out, why that
would be the case, as it's defaults to false and RevCommit handler
doesn't seem to have a logic that would override that either.

In any case, defining Arguments like this is unnecessary as it's
sufficient to define a single ArrayList @Argument that will accumulate
all commits.

Change-Id: Ifd1278b3059f86618db05bfe264dd5c00879d82b
org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/MergeBase.java