]> source.dussan.org Git - gitea.git/commit
Improve user experience for outdated comments (#29050) (#29086)
authorGiteabot <teabot@gitea.io>
Thu, 8 Feb 2024 02:29:54 +0000 (10:29 +0800)
committerGitHub <noreply@github.com>
Thu, 8 Feb 2024 02:29:54 +0000 (10:29 +0800)
commitc9b2aaed0edfc93852f30c3d1d739f0513da62e1
tree6cf86db5fc734dbd026b5990768b5de29a541634
parent19a08c7fe22e64d837dea69a395e36ad72bbf76f
Improve user experience for outdated comments (#29050) (#29086)

Backport #29050 by wxiaoguang

Try to improve #28949

1. Make `ctx.Data["ShowOutdatedComments"] = true` by default: it brings
consistent user experience, and sometimes the "outdated (source
changed)" comments are still valuable.
2. Show a friendly message if the comment won't show, then the end users
won't fell that "the comment disappears" (it is the special case when
`ShowOutdatedComments = false`)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
modules/contexttest/context_tests.go
routers/web/repo/middlewares.go
routers/web/repo/pull_review.go
routers/web/repo/pull_review_test.go [new file with mode: 0644]
templates/repo/diff/conversation_outdated.tmpl [new file with mode: 0644]