]> source.dussan.org Git - jgit.git/commit
sshd: work around a race condition in Apache MINA sshd 2.4.0/2.5.x 83/167183/6
authorThomas Wolf <thomas.wolf@paranor.ch>
Mon, 3 Aug 2020 14:22:37 +0000 (16:22 +0200)
committerThomas Wolf <thomas.wolf@paranor.ch>
Mon, 10 Aug 2020 08:20:06 +0000 (10:20 +0200)
commitcc9975ff68158a602fde8fb1c396e164081262ab
tree7562d0884d49d779d6b772e060fe0bba9a215613
parent76f79bc36c7c9130550459ace957703f1511b08d
sshd: work around a race condition in Apache MINA sshd 2.4.0/2.5.x

When exceptions occur very early in the SSH connection setup, it's
possible that an exception gets lost. A subsequent authentication
attempt may then never be notified of the failure, and then wait
indefinitely or until its timeout expires.

This is caused by race conditions in sshd. The issue has been reported
upstream as SSHD-1050,[1] but will be fixed at the earliest in sshd
2.6.0.

[1] https://issues.apache.org/jira/projects/SSHD/issues/SSHD-1050

Bug: 565394
Change-Id: If9b62839db38f9e59a5e1137c2257039ba82de98
Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
org.eclipse.jgit.ssh.apache.test/tst/org/eclipse/jgit/transport/sshd/ApacheSshTest.java
org.eclipse.jgit.ssh.apache/resources/org/eclipse/jgit/internal/transport/sshd/SshdText.properties
org.eclipse.jgit.ssh.apache/src/org/eclipse/jgit/internal/transport/sshd/JGitClientSession.java
org.eclipse.jgit.ssh.apache/src/org/eclipse/jgit/internal/transport/sshd/SshdText.java