]> source.dussan.org Git - gitea.git/commit
Add email validity check (#13475)
authorChris Shyi <chrisshyi13@gmail.com>
Sat, 14 Nov 2020 16:53:43 +0000 (00:53 +0800)
committerGitHub <noreply@github.com>
Sat, 14 Nov 2020 16:53:43 +0000 (11:53 -0500)
commitd025d84d91a43a691d748323cd74d0fdc5ecc9bf
tree37b2954066d4a3bce3eb4e79598bc37e14d3e8ea
parent7d2700c8be5da8f2073a576dae209ae07ac6ed22
Add email validity check (#13475)

* Improve error feedback for duplicate deploy keys

Instead of a generic HTTP 500 error page, a flash message is rendered
with the deploy key page template so inform the user that a key with the
intended title already exists.

* API returns 422 error when key with name exists

* Add email validity checking

Add email validity checking for the following routes:
[Web interface]
1. User registration
2. User creation by admin
3. Adding an email through user settings
[API]
1. POST /admin/users
2. PATCH /admin/users/:username
3. POST /user/emails

* Add further tests

* Add signup email tests

* Add email validity check for linking existing account

* Address PR comments

* Remove unneeded DB session

* Move email check to updateUser

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
13 files changed:
integrations/api_admin_test.go
integrations/signup_test.go
models/error.go
models/user.go
models/user_mail.go
models/user_test.go
options/locale/locale_en-US.ini
routers/admin/users.go
routers/admin/users_test.go
routers/api/v1/admin/user.go
routers/api/v1/user/email.go
routers/user/auth.go
routers/user/setting/account.go