]> source.dussan.org Git - jgit.git/commit
Allow trailing newlines in receive-pack 65/49965/5
authorDave Borowitz <dborowitz@google.com>
Wed, 10 Jun 2015 19:47:04 +0000 (12:47 -0700)
committerDave Borowitz <dborowitz@google.com>
Wed, 10 Jun 2015 22:37:55 +0000 (15:37 -0700)
commitd43703624ce4ac3379a4632b3dbf1049cd96c918
tree0aec132f5cd474999133e6998f5952b4d3472865
parent2508f1695f38e450ed320bafdd6b94fedabf116d
Allow trailing newlines in receive-pack

C git's receive-pack.c strips trailing newlines in command lists when
present[1], although send-pack.c does not send them, at least in the
case of command lists[2]. Change JGit to match this behavior.
Add tests.

This also fixes parsing of commands in the push cert, which, unlike
commands sent in the non-push case, always have trailing newlines.

[1] https://github.com/git/git/blob/7974889a053574e449b55ca543a486e38e74864f/builtin/receive-pack.c#L1380
where packet_read_line chomps newlines:
https://github.com/git/git/blob/7974889a053574e449b55ca543a486e38e74864f/pkt-line.c#L202

[2] https://github.com/git/git/blob/7974889a053574e449b55ca543a486e38e74864f/send-pack.c#L470

Change-Id: I4bca6342a7482a53c9a5815a94b3c181a479d04b
org.eclipse.jgit.test/tst/org/eclipse/jgit/transport/BaseReceivePackTest.java [new file with mode: 0644]
org.eclipse.jgit/src/org/eclipse/jgit/transport/BaseReceivePack.java