]> source.dussan.org Git - jquery.git/commit
Tests: migrate testing infrastructure to minimal dependencies
authorTimmy Willison <timmywil@users.noreply.github.com>
Mon, 26 Feb 2024 14:42:10 +0000 (09:42 -0500)
committerGitHub <noreply@github.com>
Mon, 26 Feb 2024 14:42:10 +0000 (09:42 -0500)
commitdfc693ea25fe85e5f29da23752b0c7c8d285fbf0
tree4ff805bcfa3eb07c77db318bca85aadcf0113589
parentbf11739f6c6926bc9bc1b5a1460505d3b7ef8b01
Tests: migrate testing infrastructure to minimal dependencies

This is a complete rework of our testing infrastructure. The main goal is to modernize and drop deprecated or undermaintained dependencies (specifically, grunt, karma, and testswarm). We've achieved that by limiting our dependency list to ones that are unlikely to drop support any time soon. The new dependency list includes:

- `qunit` (our trusty unit testing library)
- `selenium-webdriver` (for spinning up local browsers)
- `express` (for starting a test server and adding middleware)
  - express middleware includes uses of `body-parser` and `raw-body`
- `yargs` (for constructing a CLI with pretty help text)
- BrowserStack (for running each of our QUnit modules separately in all of our supported browsers)
  - `browserstack-local` (for opening a local tunnel. This is the same package still currently used in the new Browserstack SDK)
  - We are not using any other BrowserStack library. The newest BrowserStack SDK does not fit our needs (and isn't open source). Existing libraries, such as `node-browserstack` or `browserstack-runner`, either do not quite fit our needs, are under-maintained and out-of-date, or are not robust enough to meet all of our requirements. We instead call the [BrowserStack REST API](https://github.com/browserstack/api) directly.

## BrowserStack Runner
- automatically retries individual modules in case of test failure(s)
- automatically attempts to re-establish broken tunnels
- automatically refreshes the page in case a test run has stalled
- runs all browsers concurrently and uses as many sessions as are available under the BrowserStack plan. It will wait for available sessions if there are none.
- supports filtering the available list of browsers by browser name, browser version, device, OS, and OS version (see `npm run test:unit -- --list-browsers` for more info). It will retrieve the latest matching browser available if any of those parameters are not specified.
- cleans up after itself (closes the local tunnel, stops the test server, etc.)
- Requires `BROWSERSTACK_USERNAME` and `BROWSERSTACK_ACCESS_KEY` environment variables.

## Selenium Runner
- supports running any local browser as long as the driver is installed, including support for headless mode in Chrome, FF, and Edge
- supports running `basic` tests on the latest [jsdom](https://github.com/jsdom/jsdom#readme), which can be seen in action in this PR (see `test:browserless`)
- Node tests will run as before in PRs and all non-dependabot branches, but now includes tests on real Safari in a GH actions macos image instead of playwright-webkit.
- can run multiple browsers and multiple modules concurrently

Other notes:
- Stale dependencies have been removed and all remaining dependencies have been upgraded with a few exceptions:
  - `sinon`: stopped supporting IE in version 10. But, `sinon` has been updated to 9.x.
  - `husky`: latest does not support Node 10 and runs on `npm install`. Needed for now until git builds are migrated to GitHub Actions.
  - `rollup`: latest does not support Node 10. Needed for now until git builds are migrated to GitHub Actions.
- BrowserStack tests are set to run on each `main` branch commit
- `debug` mode leaves Selenium browsers open whether they pass or fail and leaves browsers with test failures open on BrowserStack. The latter is to avoid leaving open too many sessions.
- This PR includes a workflow to dispatch BrowserStack runs on-demand
- The Node version used for most workflow tests has been upgraded to 20.x
- updated supportjQuery to 3.7.1

Run `npm run test:unit -- --help` for CLI documentation

Close gh-5418
50 files changed:
.github/workflows/browserstack-dispatch.yml [new file with mode: 0644]
.github/workflows/browserstack.yml [new file with mode: 0644]
.github/workflows/node.js.yml
.gitignore
CONTRIBUTING.md
Gruntfile.cjs [deleted file]
build/grunt-tasks/testswarm.js [deleted file]
build/tasks/lib/verifyNodeVersion.js
build/tasks/minify.js
eslint.config.js
package-lock.json
package.json
test/data/core/dynamic_ready.html
test/data/jquery-1.9.1.js [deleted file]
test/data/jquery-3.7.1.js [new file with mode: 0644]
test/data/testinit-jsdom.js [deleted file]
test/data/testinit.js
test/index.html
test/jquery.js
test/karma.context.html [deleted file]
test/karma.debug.html [deleted file]
test/middleware-mockserver.cjs
test/runner/browsers.js [new file with mode: 0644]
test/runner/browserstack/api.js [new file with mode: 0644]
test/runner/browserstack/buildBrowserFromString.js [new file with mode: 0644]
test/runner/browserstack/createAuthHeader.js [new file with mode: 0644]
test/runner/browserstack/local.js [new file with mode: 0644]
test/runner/browserstack/workers.js [new file with mode: 0644]
test/runner/command.js [new file with mode: 0644]
test/runner/createTestServer.js [new file with mode: 0644]
test/runner/jsdom.js [new file with mode: 0644]
test/runner/lib/buildTestUrl.js [new file with mode: 0644]
test/runner/lib/generateHash.js [new file with mode: 0644]
test/runner/lib/getBrowserString.js [new file with mode: 0644]
test/runner/lib/prettyMs.js [new file with mode: 0644]
test/runner/listeners.js [new file with mode: 0644]
test/runner/modules.js [new file with mode: 0644]
test/runner/queue.js [new file with mode: 0644]
test/runner/reporter.js [new file with mode: 0644]
test/runner/run.js [new file with mode: 0644]
test/runner/selenium/createDriver.js [new file with mode: 0644]
test/runner/selenium/runSelenium.js [new file with mode: 0644]
test/runner/server.js [new file with mode: 0644]
test/server.js [deleted file]
test/unit/ajax.js
test/unit/animation.js
test/unit/event.js
test/unit/manipulation.js
test/unit/selector.js
test/unit/support.js