]> source.dussan.org Git - gitea.git/commit
Refactor some Str2html code (#29397)
authorwxiaoguang <wxiaoguang@gmail.com>
Fri, 1 Mar 2024 07:11:51 +0000 (15:11 +0800)
committerGitHub <noreply@github.com>
Fri, 1 Mar 2024 07:11:51 +0000 (07:11 +0000)
commite71eb8930a5d0f60874b038c223498b41ad65592
treef95ac2c5ed1854929ef63dddeddf8720963477f5
parent58ce1de994c2a036ebf7137c143ce193694d740d
Refactor some Str2html code (#29397)

This PR touches the most interesting part of the "template refactoring".

1. Unclear variable type. Especially for "web/feed/convert.go":
sometimes it uses text, sometimes it uses HTML.
2. Assign text content to "RenderedContent" field, for example: `
project.RenderedContent = project.Description` in web/org/projects.go
3. Assign rendered content to text field, for example: `r.Note =
rendered content` in web/repo/release.go
4. (possible) Incorrectly calling `{{Str2html
.PackageDescriptor.Metadata.ReleaseNotes}}` in
package/content/nuget.tmpl, I guess the name Str2html misleads
developers to use it to "render string to html", but it only sanitizes.
if ReleaseNotes really contains HTML, then this is not a problem.
32 files changed:
models/issues/comment.go
models/issues/issue.go
models/issues/milestone.go
models/project/project.go
models/repo/release.go
modules/markup/html_test.go
modules/markup/markdown/markdown.go
modules/markup/markdown/markdown_test.go
modules/templates/util_render.go
modules/templates/util_string.go
routers/web/feed/convert.go
routers/web/feed/profile.go
routers/web/org/projects.go
routers/web/repo/issue.go
routers/web/repo/release.go
templates/mail/release.tmpl
templates/org/header.tmpl
templates/org/home.tmpl
templates/package/content/nuget.tmpl
templates/projects/list.tmpl
templates/projects/view.tmpl
templates/repo/diff/comments.tmpl
templates/repo/issue/milestone_issues.tmpl
templates/repo/issue/milestones.tmpl
templates/repo/issue/view_content.tmpl
templates/repo/issue/view_content/attachments.tmpl
templates/repo/issue/view_content/comments.tmpl
templates/repo/issue/view_content/conversation.tmpl
templates/repo/release/list.tmpl
templates/shared/user/profile_big_avatar.tmpl
templates/user/dashboard/milestones.tmpl
templates/user/profile.tmpl