]> source.dussan.org Git - jgit.git/commit
Fix that exceptions in ReceivePack cause Invalid Channel 101 exceptions 12/48112/9
authorChristian Halstrick <christian.halstrick@sap.com>
Mon, 18 May 2015 22:45:42 +0000 (00:45 +0200)
committerMatthias Sohn <matthias.sohn@sap.com>
Wed, 27 May 2015 21:52:53 +0000 (23:52 +0200)
commitebfd62433a58d23af221adfdffed56d9274f4268
treec2902d7e92ed6f28052d244238317758715e0967
parent261b514ceb4271275d7ea68b20eee109442e0af4
Fix that exceptions in ReceivePack cause Invalid Channel 101 exceptions

When during a PushOperation the server hits an exception different from
UnpackException the JGit server behaved wrong. That kind of exceptions
are handled so late that the connection is already released and the
information whether to talk sideband to the client is lost. In detail:
ReceivePack.receive() will call release() and that will reset the
capabilities. But later on the stack in ReceivePackServlet.doPost() it
is tried to send a response to client now with reset capabilities (no
sideband!).

Change-Id: I0a609acc6152ab43b47a93d712deb65bb1105f75
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/GitServletResponseTests.java [new file with mode: 0644]
org.eclipse.jgit/src/org/eclipse/jgit/transport/BaseReceivePack.java
org.eclipse.jgit/src/org/eclipse/jgit/transport/ReceivePack.java