]> source.dussan.org Git - gitea.git/commit
Refactor repo commit list (#23690)
authorwxiaoguang <wxiaoguang@gmail.com>
Mon, 27 Mar 2023 14:44:51 +0000 (22:44 +0800)
committerGitHub <noreply@github.com>
Mon, 27 Mar 2023 14:44:51 +0000 (15:44 +0100)
commitec261b63e14f84da3e2d9a6e27c8b831a7750677
treec5e8775065780d0c8c3c3b3088482081869e4030
parentb78c955958301dde72d8caf189531f6e53c496b4
Refactor repo commit list (#23690)

### Before

* The check of `if PullRequest.BaseRepo.Name` doesn't make sense,
because the `$commitLink` is always constructed below
* Many `if` blocks make the HTML tags (likely) not match in IDE.
Although the rendered result matches, it's very unfriendly to editors or
code analyzer, and it's difficult to read.

### After

Move the `$commitLink` assignment ahead.

Simplify the code, resolve the above problems.
templates/repo/commits_list_small.tmpl