]> source.dussan.org Git - jgit.git/commit
ObjectDownloadListener: Return from onWritePossible when data is written 73/129473/3
authorDavid Ostrovsky <david@ostrovsky.org>
Sat, 15 Sep 2018 19:09:51 +0000 (21:09 +0200)
committerDavid Pursehouse <david.pursehouse@gmail.com>
Sun, 16 Sep 2018 00:20:55 +0000 (19:20 -0500)
commitf8e514c74a039209488ef56948c784c00a1d87b3
treef5ac5280752a8e6cd60ba0b95853318afe53fbb0
parente6e9073fc790009f4f7c1b31e5cfea1474972ecc
ObjectDownloadListener: Return from onWritePossible when data is written

When buffer was written not only call AsyncContext#complete() but also
return from the ObjectDownloadListener#onWritePossible(). This avoids
endless loop after upgrading from Jetty 9.3.x to 9.4.x lines.

In Jetty example implementation:[1] the return statemnt is also used:

  // If we are at EOF then complete
  if (len < 0)
  {
    async.complete();
    return;
  }

See also this issue upstream: [2].

[1] https://webtide.com/servlet-3-1-async-io-and-jetty
[2] https://github.com/eclipse/jetty.project/issues/2911

Change-Id: Iac73fb25e67d40228a378a8e34103f1d28b72a76
Signed-off-by: David Ostrovsky <david@ostrovsky.org>
org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/fs/ObjectDownloadListener.java