]> source.dussan.org Git - gitea.git/commit
Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634)
authorLunny Xiao <xiaolunwen@gmail.com>
Fri, 26 May 2023 01:04:48 +0000 (09:04 +0800)
committerGitHub <noreply@github.com>
Fri, 26 May 2023 01:04:48 +0000 (01:04 +0000)
commitf9cfd6ce5bd7f27e2655fd307022461a802fc49c
tree9279cab7249c1c7e66a81e694f1096e709c1a8a1
parent26fa94bc25ecba731a12af16b6172768389287a7
Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634)

This PR replaces all string refName as a type `git.RefName` to make the
code more maintainable.

Fix #15367
Replaces #23070
It also fixed a bug that tags are not sync because `git remote --prune
origin` will not remove local tags if remote removed.

We in fact should use `git fetch --prune --tags origin` but not `git
remote update origin` to do the sync.

Some answer from ChatGPT as ref.

> If the git fetch --prune --tags command is not working as expected,
there could be a few reasons why. Here are a few things to check:
>
>Make sure that you have the latest version of Git installed on your
system. You can check the version by running git --version in your
terminal. If you have an outdated version, try updating Git and see if
that resolves the issue.
>
>Check that your Git repository is properly configured to track the
remote repository's tags. You can check this by running git config
--get-all remote.origin.fetch and verifying that it includes
+refs/tags/*:refs/tags/*. If it does not, you can add it by running git
config --add remote.origin.fetch "+refs/tags/*:refs/tags/*".
>
>Verify that the tags you are trying to prune actually exist on the
remote repository. You can do this by running git ls-remote --tags
origin to list all the tags on the remote repository.
>
>Check if any local tags have been created that match the names of tags
on the remote repository. If so, these local tags may be preventing the
git fetch --prune --tags command from working properly. You can delete
local tags using the git tag -d command.

---------

Co-authored-by: delvh <dev.lh@web.de>
41 files changed:
cmd/hook.go
models/actions/run.go
models/activities/action.go
modules/actions/workflows.go
modules/git/ref.go
modules/git/ref_test.go [new file with mode: 0644]
modules/git/repo_branch.go
modules/git/utils.go
modules/git/utils_test.go [deleted file]
modules/notification/action/action.go
modules/notification/base/notifier.go
modules/notification/base/null.go
modules/notification/indexer/indexer.go
modules/notification/notification.go
modules/private/hook.go
modules/repository/push.go
modules/repository/repo.go
routers/api/actions/runner/utils.go
routers/private/hook_post_receive.go
routers/private/hook_pre_receive.go
routers/web/repo/branch.go
routers/web/repo/issue.go
services/actions/notifier.go
services/actions/notifier_helper.go
services/agit/agit.go
services/issue/issue.go
services/mirror/mirror_pull.go
services/mirror/mirror_test.go [new file with mode: 0644]
services/release/release.go
services/repository/branch.go
services/repository/cache.go
services/repository/push.go
services/webhook/dingtalk.go
services/webhook/discord.go
services/webhook/feishu.go
services/webhook/matrix.go
services/webhook/msteams.go
services/webhook/notifier.go
services/webhook/slack.go
services/webhook/telegram.go
services/webhook/wechatwork.go