]> source.dussan.org Git - gitea.git/commit
Make "install page" respect environment config (#25648)
authorwxiaoguang <wxiaoguang@gmail.com>
Sun, 9 Jul 2023 22:43:37 +0000 (06:43 +0800)
committerGitHub <noreply@github.com>
Sun, 9 Jul 2023 22:43:37 +0000 (22:43 +0000)
commitfa0b5b14c2faa6a5f76bb2e7bc9241a5e4354189
tree885a32e803e934883ca047116441f56ac9435b5b
parent61e0d1a767e1a1a509de9de4aff42bdb79cc6443
Make "install page" respect environment config (#25648)

Replace #25580

Fix #19453

The problem was: when users set "GITEA__XXX__YYY" , the "install page"
doesn't respect it.

So, to make the result consistent and avoid surprising end users, now
the "install page" also writes the environment variables to the config
file.

And, to make things clear, there are enough messages on the UI to tell
users what will happen.

There are some necessary/related changes to `environment-to-ini.go`:

* The "--clear" flag is removed and it was incorrectly written there.
The "clear" operation should be done if INSTALL_LOCK=true
* The "--prefix" flag is removed because it's never used, never
documented and it only causes inconsistent behavior.

![image](https://github.com/go-gitea/gitea/assets/2114189/12778ee4-3fb5-4664-a73a-41ebbd77cd5b)
13 files changed:
contrib/environment-to-ini/environment-to-ini.go
docs/content/doc/installation/with-docker-rootless.en-us.md
docs/content/doc/installation/with-docker.en-us.md
modules/assetfs/layered.go
modules/setting/config_env.go
modules/setting/config_env_test.go
modules/setting/path.go
modules/setting/security.go
modules/setting/setting.go
options/locale/locale_en-US.ini
routers/install/install.go
templates/install.tmpl
web_src/css/install.css