]> source.dussan.org Git - jgit.git/commit
Fix PackWriterBitmapWalker handling non-existing uninteresting objects 06/33906/5
authorChristian Halstrick <christian.halstrick@sap.com>
Thu, 25 Sep 2014 15:29:35 +0000 (17:29 +0200)
committerMatthias Sohn <matthias.sohn@sap.com>
Thu, 25 Sep 2014 23:01:42 +0000 (19:01 -0400)
commitfa4f00b7ed248d420ba12c576f944e873a3b8095
tree66cf119a1296933b2ca8d085e66804291bc28ac8
parent6d00f0a09c67421d4ac9960c568f9c18ceb4a6a4
Fix PackWriterBitmapWalker handling non-existing uninteresting objects

When writing new packs it should be allowed to specify objects as "have"
(objects which should not be included in the pack) which do not exist in
the local repository.

This works with the traditional PackWriter, but when PackWriter was
working on a repository with bitmap indexes and used
PackWriterBitmapWalker then this feature was broken. Non-existing "have"
objects lead to MissingObjectExceptions. That broke push and Gerrit
replication. When the replication target had branches unknown to the
replication source then the source repository wanted to build pack files
where "have" included branch-tips which were unknown in the source
repository.

Bug: 427107
Change-Id: I6b6598a1ec49af68aa77ea6f1f06e827982ea4ac
Also-by: Matthias Sohn <matthias.sohn@sap.com>
org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/file/PackWriterTest.java
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/pack/PackWriter.java
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/pack/PackWriterBitmapWalker.java