]> source.dussan.org Git - gitea.git/commit
projects / gitea.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 1bcf1ad) | patch
Always return a list from GetCommitsFromIDs (#12981)
authorzeripath <art27@cantab.net>
Tue, 29 Sep 2020 21:26:54 +0000 (22:26 +0100)
committerGitHub <noreply@github.com>
Tue, 29 Sep 2020 21:26:54 +0000 (22:26 +0100)
commitfe79b13ab2ce9526fae10a5257b4e171cae30ecb
tree1b846b92b99e07423f744a683440de8843832d47tree | snapshot
parent1bcf1ad6434e45c28b9232032284299334663026commit | diff
Always return a list from GetCommitsFromIDs (#12981)

`GetCommitsFromIDs` is only used in one place: `LoadPushCommits` where
it expects that `c.Commits` is not nil.

This potentially nil set causes a NPE in in #12953

Fix #12953

Signed-off-by: Andrew Thornton <art27@cantab.net>
modules/git/repo_commit.go diff | blob | history
Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD: https://github.com/go-gitea/gitea