]> source.dussan.org Git - jgit.git/commit
projects / jgit.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 7b365b2) | patch
Fix logging null if called process fails 09/129009/4
authorCliffred van Velzen <cliffred@cliffred.nl>
Mon, 10 Sep 2018 06:45:01 +0000 (08:45 +0200)
committerMatthias Sohn <matthias.sohn@sap.com>
Wed, 12 Sep 2018 21:42:35 +0000 (23:42 +0200)
commit0c8200b27b60baafd81bbaeeec0eb671891308e5
tree05dd79e7320dded51e001f891ac030f8321c4fa4tree | snapshot
parent7b365b2faa1c1568216040b6e3412c6bc1372e54commit | diff
Fix logging null if called process fails

If some process executed by FS#readPipe ends in an error,
the error stream is never set as errorMessage because
FS#GobblerThread#waitForProcessCompletion always returned true.
This caused LOG#warn to be called with null.

Return false whenever FS#GobblerThread#waitForProcessCompletion fails.

Bug: 538723
Change-Id: Ic9492bd688431d52c8665f7a2efec2989e95a4ce
Signed-off-by: Cliffred van Velzen <cliffred@cliffred.nl>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
org.eclipse.jgit/src/org/eclipse/jgit/util/FS.java diff | blob | history
JGit, the Java implementation of git: https://github.com/eclipse-jgit/jgit