]> source.dussan.org Git - jgit.git/commit
DfsReaderIoStats: Clarify that "blocks" are really cache misses 64/115264/2
authorDave Borowitz <dborowitz@google.com>
Thu, 11 Jan 2018 18:14:02 +0000 (13:14 -0500)
committerDavid Pursehouse <david.pursehouse@gmail.com>
Thu, 22 Feb 2018 07:27:09 +0000 (16:27 +0900)
commit879372eb72d8b8a073f4f73d98caa1cd15971bd5
tree0ce0484415722a2468c0c853195348b84b127105
parent49cb6ba5dd337dfdc9302bb33248e8448f530d3d
DfsReaderIoStats: Clarify that "blocks" are really cache misses

The previous wording was ambiguous as to whether these were blocks
requested from the cache (hits + misses) or read from underlying storage
(misses only).

They are in fact recording only misses:
Accumulator#{readBlock,readBlockBytes,readBlockMicros} are only
incremented from BlockBasedFile#readOneBlock, which is only called from
the cache miss path in DfsBlockCache#getOrLoad (line 391).

Change-Id: I0135cd1e76d09c1e28e0f1833b34c312511c66ce
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/DfsReaderIoStats.java