]> source.dussan.org Git - poi.git/commitdiff
sonar fixes
authorAndreas Beeker <kiwiwings@apache.org>
Sun, 4 Oct 2015 00:35:30 +0000 (00:35 +0000)
committerAndreas Beeker <kiwiwings@apache.org>
Sun, 4 Oct 2015 00:35:30 +0000 (00:35 +0000)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706648 13f79535-47bb-0310-9956-ffa450edef68

13 files changed:
src/java/org/apache/poi/hpsf/Section.java
src/java/org/apache/poi/poifs/filesystem/BlockStore.java
src/java/org/apache/poi/poifs/property/NPropertyTable.java
src/java/org/apache/poi/poifs/storage/BATBlock.java
src/java/org/apache/poi/ss/formula/functions/AggregateFunction.java
src/java/org/apache/poi/ss/formula/functions/NumericFunction.java
src/java/org/apache/poi/ss/usermodel/FractionFormat.java
src/java/org/apache/poi/ss/util/ImageUtils.java
src/java/org/apache/poi/util/HexDump.java
src/ooxml/java/org/apache/poi/openxml4j/opc/internal/PackagePropertiesPart.java
src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFSlideShow.java
src/scratchpad/src/org/apache/poi/hwpf/converter/AbstractWordConverter.java
src/scratchpad/src/org/apache/poi/hwpf/sprm/CharacterSprmUncompressor.java

index 787462c6358024d009c3cac2a5ab89aaf6d90804..b473572100d700d8ea87e59eef370d1a1a8d9e58 100644 (file)
@@ -150,6 +150,7 @@ public class Section
      * @exception UnsupportedEncodingException if the section's codepage is not
      * supported.
      */
+    @SuppressWarnings("unchecked")
     public Section(final byte[] src, final int offset)
     throws UnsupportedEncodingException
     {
@@ -332,19 +333,25 @@ public class Section
 
 
         public boolean equals(Object obj) {
-            if (this == obj)
+            if (this == obj) {
                 return true;
-            if (obj == null)
+            }
+            if (obj == null) {
                 return false;
-            if (getClass() != obj.getClass())
+            }
+            if (getClass() != obj.getClass()) {
                 return false;
+            }
             PropertyListEntry other = (PropertyListEntry) obj;
-            if (id != other.id)
+            if (id != other.id) {
                 return false;
-            if (length != other.length)
+            }
+            if (length != other.length) {
                 return false;
-            if (offset != other.offset)
+            }
+            if (offset != other.offset) {
                 return false;
+            }
             return true;
         }
 
index 0ef8082270350d0fab2d39a97e89e5cd614bd3fd..a56d111f3fe82a10cea83321a05f7f8e5e0f9789 100644 (file)
@@ -80,7 +80,11 @@ public abstract class BlockStore {
     protected class ChainLoopDetector {
        private boolean[] used_blocks;
        protected ChainLoopDetector(long rawSize) {
-          int numBlocks = (int)Math.ceil( ((double)rawSize) / getBlockStoreBlockSize() );
+          int blkSize = getBlockStoreBlockSize();
+          int numBlocks = (int)(rawSize / blkSize);
+          if ((rawSize % blkSize) != 0) {
+              numBlocks++;
+          }
           used_blocks = new boolean[numBlocks];
        }
        protected void claim(int offset) {
index ec38ddecb22b0af108d96c979026a679eb3f9a46..5528064086ce8efddbbbffebee41847307bb17b8 100644 (file)
@@ -119,8 +119,13 @@ public final class NPropertyTable extends PropertyTableBase {
      */
     public int countBlocks()
     {
-       int size = _properties.size() * POIFSConstants.PROPERTY_SIZE;
-       return (int)Math.ceil( ((double)size) / _bigBigBlockSize.getBigBlockSize());
+       long rawSize = _properties.size() * POIFSConstants.PROPERTY_SIZE;
+       int blkSize = _bigBigBlockSize.getBigBlockSize();
+       int numBlocks = (int)(rawSize / blkSize);
+       if ((rawSize % blkSize) != 0) {
+           numBlocks++;
+       }
+       return numBlocks;
     }
  
     /**
index 53099644ac325243f9ac84e1e0056633e5d76d79..b04591dde45bc9675f4430e20be7e562c473b2da 100644 (file)
@@ -265,9 +265,10 @@ public final class BATBlock extends BigBlock {
     public static BATBlockAndIndex getBATBlockAndIndex(final int offset, 
                 final HeaderBlock header, final List<BATBlock> bats) {
        POIFSBigBlockSize bigBlockSize = header.getBigBlockSize();
+       int entriesPerBlock = bigBlockSize.getBATEntriesPerBlock();
        
-       int whichBAT = (int)Math.floor(offset / bigBlockSize.getBATEntriesPerBlock());
-       int index = offset % bigBlockSize.getBATEntriesPerBlock();
+       int whichBAT = offset / entriesPerBlock;
+       int index = offset % entriesPerBlock;
        return new BATBlockAndIndex( index, bats.get(whichBAT) );
     }
     
@@ -279,10 +280,11 @@ public final class BATBlock extends BigBlock {
     public static BATBlockAndIndex getSBATBlockAndIndex(final int offset, 
           final HeaderBlock header, final List<BATBlock> sbats) {
        POIFSBigBlockSize bigBlockSize = header.getBigBlockSize();
+       int entriesPerBlock = bigBlockSize.getBATEntriesPerBlock();
        
        // SBATs are so much easier, as they're chained streams
-       int whichSBAT = (int)Math.floor(offset / bigBlockSize.getBATEntriesPerBlock());
-       int index = offset % bigBlockSize.getBATEntriesPerBlock();
+       int whichSBAT = offset / entriesPerBlock;
+       int index = offset % entriesPerBlock;
        return new BATBlockAndIndex( index, sbats.get(whichSBAT) );
     }
     
index 084355d3037ec44a6433948732e85bab6c50ffa8..644086d31edc6c1f2fd7e156fecf87dbb78cd31e 100644 (file)
@@ -115,7 +115,7 @@ public abstract class AggregateFunction extends MultiOperandNumericFunction {
                                double n = (N - 1) * dn + 1;
                                if (n == 1d) {
                                        result = StatsLib.kthSmallest(ds, 1);
-                               } else if (n == N) {
+                               } else if (Double.compare(n, N) == 0) {
                                        result = StatsLib.kthLargest(ds, 1);
                                } else {
                                        int k = (int) n;
index 38d8006537e3dcf13c14cd7230892be0d329be91..72be101ca75d6566d2e374b7a14fd2955c8bfe40 100644 (file)
@@ -366,7 +366,7 @@ public abstract class NumericFunction implements Function {
                                double d1 = NumericFunction.singleOperandEvaluate(arg1, srcRowIndex, srcColumnIndex);
                                double logE = Math.log(d0);
                                double base = d1;
-                               if (base == Math.E) {
+                               if (Double.compare(base, Math.E) == 0) {
                                        result = logE;
                                } else {
                                        result = logE / Math.log(base);
index 202ccdae229dbdf1e2d33ae973e61c236a815e8d..b371c4ec84373e293d7f301028e3905f41142260 100644 (file)
@@ -24,6 +24,8 @@ import java.util.regex.Pattern;
 \r
 import org.apache.poi.ss.format.SimpleFraction;\r
 import org.apache.poi.ss.formula.eval.NotImplementedException;\r
+import org.apache.poi.util.POILogFactory;\r
+import org.apache.poi.util.POILogger;\r
 \r
 /**\r
  * <p>Format class that handles Excel style fractions, such as "# #/#" and "#/###"</p>\r
@@ -39,7 +41,8 @@ import org.apache.poi.ss.formula.eval.NotImplementedException;
 \r
 @SuppressWarnings("serial")\r
 public class FractionFormat extends Format {\r
-    private final static Pattern DENOM_FORMAT_PATTERN = Pattern.compile("(?:(#+)|(\\d+))");\r
+    private static final POILogger LOGGER = POILogFactory.getLogger(FractionFormat.class); \r
+    private static final Pattern DENOM_FORMAT_PATTERN = Pattern.compile("(?:(#+)|(\\d+))");\r
 \r
     //this was chosen to match the earlier limitation of max denom power\r
     //it can be expanded to get closer to Excel's calculations\r
@@ -47,7 +50,7 @@ public class FractionFormat extends Format {
     //but as of this writing, the numerators and denominators\r
     //with formats of that nature on very small values were quite\r
     //far from Excel's calculations\r
-    private final static int MAX_DENOM_POW = 4;\r
+    private static final int MAX_DENOM_POW = 4;\r
 \r
     //there are two options:\r
     //a) an exact denominator is specified in the formatString\r
@@ -133,7 +136,7 @@ public class FractionFormat extends Format {
                 fract = SimpleFraction.buildFractionMaxDenominator(decPart, maxDenom);\r
             }\r
         } catch (RuntimeException e){\r
-            e.printStackTrace();\r
+            LOGGER.log(POILogger.WARN, "Can't format fraction", e);\r
             return Double.toString(doubleValue);\r
         }\r
 \r
index 2e851416ace3510cf1cae20299c61202caa333eb..16176682ad512421bde9e6bdfcec9f96700bbe28 100644 (file)
@@ -237,7 +237,7 @@ public class ImageUtils {
         if (isHSSF) {\r
             w *= 1 - anchor.getDx1()/1024d;\r
         } else {\r
-            w -= anchor.getDx1()/EMU_PER_PIXEL;\r
+            w -= anchor.getDx1()/(double)EMU_PER_PIXEL;\r
         }\r
         \r
         while(col2 < anchor.getCol2()){\r
@@ -247,7 +247,7 @@ public class ImageUtils {
         if (isHSSF) {\r
             w += sheet.getColumnWidthInPixels(col2) * anchor.getDx2()/1024d;\r
         } else {\r
-            w += anchor.getDx2()/EMU_PER_PIXEL;\r
+            w += anchor.getDx2()/(double)EMU_PER_PIXEL;\r
         }\r
 \r
         double h = 0;\r
@@ -257,7 +257,7 @@ public class ImageUtils {
         if (isHSSF) {\r
             h *= 1 - anchor.getDy1()/256d;\r
         } else {\r
-            h -= anchor.getDy1()/EMU_PER_PIXEL;\r
+            h -= anchor.getDy1()/(double)EMU_PER_PIXEL;\r
         }\r
 \r
         while(row2 < anchor.getRow2()){\r
@@ -267,10 +267,13 @@ public class ImageUtils {
         if (isHSSF) {\r
             h += getRowHeightInPixels(sheet,row2) * anchor.getDy2()/256;\r
         } else {\r
-            h += anchor.getDy2()/EMU_PER_PIXEL;\r
+            h += anchor.getDy2()/(double)EMU_PER_PIXEL;\r
         }\r
 \r
-        return new Dimension((int)w*EMU_PER_PIXEL, (int)h*EMU_PER_PIXEL);\r
+        w *= EMU_PER_PIXEL;\r
+        h *= EMU_PER_PIXEL;\r
+        \r
+        return new Dimension((int)Math.rint(w), (int)Math.rint(h));\r
     }\r
     \r
     \r
index 1357b88f095765b06aa47a74f570af083c5c9ebe..7eb8c85068415f2887de2acc678fc69f0f21c534 100644 (file)
@@ -343,21 +343,21 @@ public class HexDump {
      * @return string of 8 (zero padded) uppercase hex chars and prefixed with '0x'
      */
     public static String intToHex(int value) {
-        return xpad(value & 0xFFFFFFFF, 8, "0x");
+        return xpad(value & 0xFFFFFFFFL, 8, "0x");
     }
     
     /**
      * @return string of 4 (zero padded) uppercase hex chars and prefixed with '0x'
      */
     public static String shortToHex(int value) {
-        return xpad(value & 0xFFFF, 4, "0x");
+        return xpad(value & 0xFFFFL, 4, "0x");
     }
     
     /**
      * @return string of 2 (zero padded) uppercase hex chars and prefixed with '0x'
      */
     public static String byteToHex(int value) {
-        return xpad(value & 0xFF, 2, "0x");
+        return xpad(value & 0xFFL, 2, "0x");
     }
 
     private static String xpad(long value, int pad, String prefix) {
index 26331fbccf9edfa99b2904f670ef4316609c3130..1d957e5a59414c01eeee014a627f32ca6b54dbd4 100644 (file)
@@ -559,20 +559,18 @@ public final class PackagePropertiesPart extends PackagePart implements
         * @throws InvalidFormatException
         *             Throws if the date format isnot valid.
         */
-       private Nullable<Date> setDateValue(String s) throws InvalidFormatException {
-               if (s == null || s.equals("")) {
+       private Nullable<Date> setDateValue(String dateStr) throws InvalidFormatException {
+               if (dateStr == null || dateStr.equals("")) {
                        return new Nullable<Date>();
                }
-               if (!s.endsWith("Z")) {
-                   s += "Z";
-               }
+               String dateTzStr = dateStr.endsWith("Z") ? dateStr : (dateStr + "Z");
                SimpleDateFormat df = new SimpleDateFormat(DEFAULT_DATEFORMAT, Locale.ROOT);
                df.setTimeZone(LocaleUtil.TIMEZONE_UTC);
-               Date d = df.parse(s, new ParsePosition(0));
+               Date d = df.parse(dateTzStr, new ParsePosition(0));
                if (d == null) {
                    df = new SimpleDateFormat(ALTERNATIVE_DATEFORMAT, Locale.ROOT);
                    df.setTimeZone(LocaleUtil.TIMEZONE_UTC);
-                   d = df.parse(s, new ParsePosition(0));
+                   d = df.parse(dateTzStr, new ParsePosition(0));
                }
                if (d == null) {
                        throw new InvalidFormatException("Date not well formated");
index 6d17cbb4c7f1a147ea9f2ad713d861115b5eb3b2..79a5bd6d7546a1002daa57f276f870c333a55ce0 100644 (file)
@@ -6,7 +6,7 @@
    (the "License"); you may not use this file except in compliance with
    the License.  You may obtain a copy of the License at
 
-       http://www.apache.org/licenses/LICENSE-2.0
+          http://www.apache.org/licenses/LICENSE-2.0
 
    Unless required by applicable law or agreed to in writing, software
    distributed under the License is distributed on an "AS IS" BASIS,
@@ -46,90 +46,90 @@ import org.openxmlformats.schemas.presentationml.x2006.main.SldMasterDocument;
 
 /**
  * Experimental class to do low level processing of pptx files.
- * 
+ *
  * Most users should use the higher level {@link XMLSlideShow} instead.
- *  
+ *
  * If you are using these low level classes, then you
  *  will almost certainly need to refer to the OOXML
  *  specifications from
  *  http://www.ecma-international.org/publications/standards/Ecma-376.htm
- * 
+ *
  * WARNING - APIs expected to change rapidly
  */
 public class XSLFSlideShow extends POIXMLDocument {
 
        private PresentationDocument presentationDoc;
-    /**
-     * The embedded OLE2 files in the OPC package
-     */
-    private List<PackagePart> embedds;
+       /**
+        * The embedded OLE2 files in the OPC package
+        */
+       private List<PackagePart> embedds;
 
-    @SuppressWarnings("deprecation")
+       @SuppressWarnings("deprecation")
        public XSLFSlideShow(OPCPackage container) throws OpenXML4JException, IOException, XmlException {
                super(container);
-               
+
                if(getCorePart().getContentType().equals(XSLFRelation.THEME_MANAGER.getContentType())) {
-                  rebase(getPackage());
+                       rebase(getPackage());
                }
-               
+
                presentationDoc =
                        PresentationDocument.Factory.parse(getCorePart().getInputStream());
-               
-      embedds = new LinkedList<PackagePart>();
-      for (CTSlideIdListEntry ctSlide : getSlideReferences().getSldIdArray()) {
-             PackagePart corePart = getCorePart();
-                 PackagePart slidePart = corePart.getRelatedPart(
-                       corePart.getRelationship(ctSlide.getId2()));
 
-                 for(PackageRelationship rel : slidePart.getRelationshipsByType(OLE_OBJECT_REL_TYPE))
-                     embedds.add(slidePart.getRelatedPart(rel)); // TODO: Add this reference to each slide as well
+               embedds = new LinkedList<PackagePart>();
+               for (CTSlideIdListEntry ctSlide : getSlideReferences().getSldIdArray()) {
+                       PackagePart corePart = getCorePart();
+                       PackagePart slidePart = corePart.getRelatedPart(corePart.getRelationship(ctSlide.getId2()));
+
+                       for(PackageRelationship rel : slidePart.getRelationshipsByType(OLE_OBJECT_REL_TYPE)) {
+                               // TODO: Add this reference to each slide as well
+                               embedds.add(slidePart.getRelatedPart(rel));
+                       }
 
-                 for(PackageRelationship rel : slidePart.getRelationshipsByType(PACK_OBJECT_REL_TYPE))
-                  embedds.add(slidePart.getRelatedPart(rel));
+                       for (PackageRelationship rel : slidePart.getRelationshipsByType(PACK_OBJECT_REL_TYPE)) {
+                               embedds.add(slidePart.getRelatedPart(rel));
+                       }
                }
        }
        public XSLFSlideShow(String file) throws OpenXML4JException, IOException, XmlException {
                this(openPackage(file));
        }
-       
+
        /**
         * Returns the low level presentation base object
         */
-    @Internal
+       @Internal
        public CTPresentation getPresentation() {
                return presentationDoc.getPresentation();
        }
-       
+
        /**
         * Returns the references from the presentation to its
         *  slides.
         * You'll need these to figure out the slide ordering,
         *  and to get at the actual slides themselves
         */
-    @Internal
+       @Internal
        public CTSlideIdList getSlideReferences() {
-       if(! getPresentation().isSetSldIdLst()) {
-          getPresentation().setSldIdLst(
-             CTSlideIdList.Factory.newInstance()   
-          );
-       }
-       return getPresentation().getSldIdLst();
+               if(! getPresentation().isSetSldIdLst()) {
+                       getPresentation().setSldIdLst(CTSlideIdList.Factory.newInstance());
+               }
+               return getPresentation().getSldIdLst();
        }
-    
+
        /**
         * Returns the references from the presentation to its
         *  slide masters.
-        * You'll need these to get at the actual slide 
+        * You'll need these to get at the actual slide
         *  masters themselves
         */
-    @Internal
+       @Internal
        public CTSlideMasterIdList getSlideMasterReferences() {
                return getPresentation().getSldMasterIdLst();
        }
-       
+
        public PackagePart getSlideMasterPart(CTSlideMasterIdListEntry master) throws IOException, XmlException {
                try {
-                  PackagePart corePart = getCorePart(); 
+                  PackagePart corePart = getCorePart();
                        return corePart.getRelatedPart(
                                corePart.getRelationship(master.getId2())
                        );
@@ -141,7 +141,7 @@ public class XSLFSlideShow extends POIXMLDocument {
         * Returns the low level slide master object from
         *  the supplied slide master reference
         */
-    @Internal
+       @Internal
        public CTSlideMaster getSlideMaster(CTSlideMasterIdListEntry master) throws IOException, XmlException {
                PackagePart masterPart = getSlideMasterPart(master);
                SldMasterDocument masterDoc =
@@ -151,10 +151,8 @@ public class XSLFSlideShow extends POIXMLDocument {
 
        public PackagePart getSlidePart(CTSlideIdListEntry slide) throws IOException, XmlException {
                try {
-             PackagePart corePart = getCorePart(); 
-             return corePart.getRelatedPart(
-                corePart.getRelationship(slide.getId2())
-             );
+                       PackagePart corePart = getCorePart();
+                       return corePart.getRelatedPart(corePart.getRelationship(slide.getId2()));
                } catch(InvalidFormatException e) {
                        throw new XmlException(e);
                }
@@ -163,7 +161,7 @@ public class XSLFSlideShow extends POIXMLDocument {
         * Returns the low level slide object from
         *  the supplied slide reference
         */
-    @Internal
+       @Internal
        public CTSlide getSlide(CTSlideIdListEntry slide) throws IOException, XmlException {
                PackagePart slidePart = getSlidePart(slide);
                SldDocument slideDoc =
@@ -178,13 +176,13 @@ public class XSLFSlideShow extends POIXMLDocument {
        public PackagePart getNodesPart(CTSlideIdListEntry parentSlide) throws IOException, XmlException {
                PackageRelationshipCollection notes;
                PackagePart slidePart = getSlidePart(parentSlide);
-               
+
                try {
                        notes = slidePart.getRelationshipsByType(XSLFRelation.NOTES.getRelation());
                } catch(InvalidFormatException e) {
                        throw new IllegalStateException(e);
                }
-               
+
                if(notes.size() == 0) {
                        // No notes for this slide
                        return null;
@@ -192,9 +190,9 @@ public class XSLFSlideShow extends POIXMLDocument {
                if(notes.size() > 1) {
                        throw new IllegalStateException("Expecting 0 or 1 notes for a slide, but found " + notes.size());
                }
-               
+
                try {
-                  return slidePart.getRelatedPart(notes.getRelationship(0));
+                       return slidePart.getRelatedPart(notes.getRelationship(0));
                } catch(InvalidFormatException e) {
                        throw new IllegalStateException(e);
                }
@@ -203,32 +201,32 @@ public class XSLFSlideShow extends POIXMLDocument {
         * Returns the low level notes object for the given
         *  slide, as found from the supplied slide reference
         */
-    @Internal
+       @Internal
        public CTNotesSlide getNotes(CTSlideIdListEntry slide) throws IOException, XmlException {
                PackagePart notesPart = getNodesPart(slide);
                if(notesPart == null)
                        return null;
-               
+
                NotesDocument notesDoc =
                        NotesDocument.Factory.parse(notesPart.getInputStream());
-               
+
                return notesDoc.getNotes();
        }
-       
+
        /**
         * Returns all the comments for the given slide
         */
-    @Internal
+       @Internal
        public CTCommentList getSlideComments(CTSlideIdListEntry slide) throws IOException, XmlException {
                PackageRelationshipCollection commentRels;
                PackagePart slidePart = getSlidePart(slide);
-               
+
                try {
                        commentRels = slidePart.getRelationshipsByType(XSLFRelation.COMMENTS.getRelation());
                } catch(InvalidFormatException e) {
                        throw new IllegalStateException(e);
                }
-               
+
                if(commentRels.size() == 0) {
                        // No comments for this slide
                        return null;
@@ -236,12 +234,12 @@ public class XSLFSlideShow extends POIXMLDocument {
                if(commentRels.size() > 1) {
                        throw new IllegalStateException("Expecting 0 or 1 comments for a slide, but found " + commentRels.size());
                }
-               
+
                try {
                        PackagePart cPart = slidePart.getRelatedPart(
                                        commentRels.getRelationship(0)
                        );
-                       CmLstDocument commDoc = 
+                       CmLstDocument commDoc =
                                CmLstDocument.Factory.parse(cPart.getInputStream());
                        return commDoc.getCmLst();
                } catch(InvalidFormatException e) {
@@ -249,12 +247,12 @@ public class XSLFSlideShow extends POIXMLDocument {
                }
        }
 
-    /**
-     * Get the document's embedded files.
-     */
-    @Override
-    public List<PackagePart> getAllEmbedds() throws OpenXML4JException {
-        return embedds;
-    }
+       /**
+        * Get the document's embedded files.
+        */
+       @Override
+       public List<PackagePart> getAllEmbedds() throws OpenXML4JException {
+               return embedds;
+       }
 
 }
index e8a3dfcf7a1a4bfe9fe3e2228fee62cbd0176791..02b2dbdaa3dc56efc4e50bf242a5ee8193a38f9b 100644 (file)
@@ -915,21 +915,23 @@ public abstract class AbstractWordConverter
             Element currentBlock, Range textRange, int currentTableLevel,
             String hyperlink );
 
-    protected void processImage( Element currentBlock, boolean inlined,
-            Picture picture )
-    {
+    protected void processImage( Element currentBlock, boolean inlined, Picture picture ) {
         PicturesManager fileManager = getPicturesManager();
-        if ( fileManager != null )
-        {
-            final int aspectRatioX = picture.getHorizontalScalingFactor();
-            final int aspectRatioY = picture.getVerticalScalingFactor();
-
-            final float imageWidth = aspectRatioX > 0 ? picture.getDxaGoal()
-                    * aspectRatioX / 1000 / AbstractWordUtils.TWIPS_PER_INCH
-                    : picture.getDxaGoal() / AbstractWordUtils.TWIPS_PER_INCH;
-            final float imageHeight = aspectRatioY > 0 ? picture.getDyaGoal()
-                    * aspectRatioY / 1000 / AbstractWordUtils.TWIPS_PER_INCH
-                    : picture.getDyaGoal() / AbstractWordUtils.TWIPS_PER_INCH;
+        if ( fileManager != null ) {
+            final float aspectRatioX = picture.getHorizontalScalingFactor();
+            final float aspectRatioY = picture.getVerticalScalingFactor();
+
+            float imageWidth = picture.getDxaGoal();
+            if (aspectRatioX > 0) {
+                imageWidth *= aspectRatioX / 1000f;
+            }
+            imageWidth /= AbstractWordUtils.TWIPS_PER_INCH;
+            
+            float imageHeight = picture.getDyaGoal();
+            if (aspectRatioY > 0) {
+                imageHeight *= aspectRatioY / 1000f;
+            }
+            imageHeight /= AbstractWordUtils.TWIPS_PER_INCH;
 
             String url = fileManager.savePicture( picture.getContent(),
                     picture.suggestPictureType(),
index d3fe6613a69b2db9a980a676a1e1943ed9230e7a..e7ce790f7a1ebdef8e4c9fc5b0273c4fba37672f 100644 (file)
@@ -381,7 +381,7 @@ public final class CharacterSprmUncompressor extends SprmUncompressor
 
         //byte cInc = (byte)(((byte)(param & 0xfe00) >>> 4) >> 1);
         byte cInc = (byte) ((operand & 0xff00) >>> 8);
-        cInc = (byte) (cInc >>> 1);
+        cInc >>>= 1;
         if (cInc != 0)
         {
           newCHP.setHps (Math.max (newCHP.getHps () + (cInc * 2), 2));