SONAR-13144 Fix unslection on multi-location issues.

diff --git a/server/sonar-web/src/main/js/apps/issues/crossComponentSourceViewer/ComponentSourceSnippetViewer.tsx b/server/sonar-web/src/main/js/apps/issues/crossComponentSourceViewer/ComponentSourceSnippetViewer.tsx
index 54ef42fb0c3bb024a663b9903bfaa5fbc430c9f6..5519d70d6b32d9d0c5cabcf542d1bbeab1949238 100644 (file)
--- a/server/sonar-web/src/main/js/apps/issues/crossComponentSourceViewer/ComponentSourceSnippetViewer.tsx
+++ b/server/sonar-web/src/main/js/apps/issues/crossComponentSourceViewer/ComponentSourceSnippetViewer.tsx
@@ -290,8 +290,13 @@ export default class ComponentSourceSnippetViewer extends React.PureComponent<Pr
     }));
   };
 
-  handleSymbolClick = (highlightedSymbols: string[]) => {
-    this.setState({ highlightedSymbols });
+  handleSymbolClick = (clickedSymbols: string[]) => {
+    this.setState(({ highlightedSymbols }) => {
+      const newHighlightedSymbols = clickedSymbols.filter(
+        symb => !highlightedSymbols.includes(symb)
+      );
+      return { highlightedSymbols: newHighlightedSymbols };
+    });
   };
 
   loadDuplications = (line: T.SourceLine) => {

diff --git a/server/sonar-web/src/main/js/apps/issues/crossComponentSourceViewer/__tests__/ComponentSourceSnippetViewer-test.tsx b/server/sonar-web/src/main/js/apps/issues/crossComponentSourceViewer/__tests__/ComponentSourceSnippetViewer-test.tsx
index 331f5b1d2b8d9486311b460fbe2efc99753f2fb7..70382f6c53da6371380aee4da389e46773e8af0b 100644 (file)
--- a/server/sonar-web/src/main/js/apps/issues/crossComponentSourceViewer/__tests__/ComponentSourceSnippetViewer-test.tsx
+++ b/server/sonar-web/src/main/js/apps/issues/crossComponentSourceViewer/__tests__/ComponentSourceSnippetViewer-test.tsx
@@ -168,6 +168,8 @@ it('should handle symbol highlighting', () => {
   expect(wrapper.state('highlightedSymbols')).toEqual([]);
   wrapper.instance().handleSymbolClick(['foo']);
   expect(wrapper.state('highlightedSymbols')).toEqual(['foo']);
+  wrapper.instance().handleSymbolClick(['foo']);
+  expect(wrapper.state('highlightedSymbols')).toEqual([]);
 });
 
 it('should correctly handle lines actions', () => {