Effects: First step() call should match :animated selector

Fixes #14623
Closes gh-1473

diff --git a/src/effects.js b/src/effects.js
index b439d8d58dfee4006233d76fc677087fc1f45d95..e3ccefff61491edbbf604a8c0794f914900396e2 100644 (file)
--- a/src/effects.js
+++ b/src/effects.js
@@ -610,8 +610,11 @@ jQuery.fx.tick = function() {
 };
 
 jQuery.fx.timer = function( timer ) {
-       if ( timer() && jQuery.timers.push( timer ) ) {
+       jQuery.timers.push( timer );
+       if ( timer() ) {
                jQuery.fx.start();
+       } else {
+               jQuery.timers.pop();
        }
 };
 

diff --git a/test/unit/effects.js b/test/unit/effects.js
index 1645842c490fd30b4bf64af4726a5981cdb48ede..318010b182582cf93920526ee8ad03ec51c9d629 100644 (file)
--- a/test/unit/effects.js
+++ b/test/unit/effects.js
@@ -1550,6 +1550,21 @@ test("Animation callback should not show animated element as :animated (#7157)",
        this.clock.tick( 100 );
 });
 
+test("Initial step callback should show element as :animated (#14623)", 1, function() {
+       var foo = jQuery( "#foo" );
+
+       foo.animate({
+               opacity: 0,
+       }, {
+               duration: 100,
+               step: function() {
+                       ok( foo.is(":animated"), "The element matches :animated inside step function" );
+               }
+       });
+       this.clock.tick( 1 );
+       foo.stop();
+});
+
 test( "hide called on element within hidden parent should set display to none (#10045)", 3, function() {
        var hidden = jQuery(".hidden"),
                elems = jQuery("<div>hide</div><div>hide0</div><div>hide1</div>");