* @param p
*/
public static double round(double n, int p) {
- double retval;
-
- if (Double.isNaN(n) || Double.isInfinite(n)) {
- retval = Double.NaN;
- }
- else {
- retval = new java.math.BigDecimal(NumberToTextConverter.toText(n)).setScale(p, java.math.RoundingMode.HALF_UP).doubleValue();
- }
-
- return retval;
+ return round(n, p, java.math.RoundingMode.HALF_UP);
}
/**
* @param p
*/
public static double roundUp(double n, int p) {
- double retval;
-
- if (Double.isNaN(n) || Double.isInfinite(n)) {
- retval = Double.NaN;
- }
- else {
- retval = java.math.BigDecimal.valueOf(n).setScale(p, java.math.RoundingMode.UP).doubleValue();
- }
-
- return retval;
+ return round(n, p, java.math.RoundingMode.UP);
}
/**
* @param p
*/
public static double roundDown(double n, int p) {
+ return round(n, p, java.math.RoundingMode.DOWN);
+ }
+
+ private static double round(double n, int p, java.math.RoundingMode rounding) {
double retval;
if (Double.isNaN(n) || Double.isInfinite(n)) {
retval = Double.NaN;
}
else {
- retval = java.math.BigDecimal.valueOf(n).setScale(p, java.math.RoundingMode.DOWN).doubleValue();
+ retval = new java.math.BigDecimal(NumberToTextConverter.toText(n)).setScale(p, rounding).doubleValue();
}
return retval;
d = 150.0; p = -2;
assertEquals("roundDown ", 100, MathX.roundDown(d, p));
- d = 0.049999999999999975d; p = 2;
+ d = 0.0499999999999975d; p = 2;
assertEquals("roundDown ", 0.04d, MathX.roundDown(d, p));
d = 0.049999999999999975d; p = 1;
d = Double.MAX_VALUE; p = 1;
assertEquals("roundUp ", Double.MAX_VALUE, MathX.roundUp(d, p));
+ // Excel's min positive value is several orders of magnitude larger than Java's (Java 8: 4.9e-324, Excel 2016 on Windows 10: 2.2259157957E-308)
d = Double.MIN_VALUE; p = 1;
+ assertEquals("roundUp ", 0.0d, MathX.roundUp(d, p));
+ d = 2.2259157957E-308; p = 1;
assertEquals("roundUp ", 0.1d, MathX.roundUp(d, p));
//github-43: https://github.com/apache/poi/pull/43
- //@Ignore("ROUNDUP(3987*0.2, 2) currently fails by returning 797.41")
- //d = 3987 * 0.2; p = 2;
- //assertEquals("roundUp ", 797.40, MathX.roundUp(d, p));
+ // "ROUNDUP(3987*0.2, 2) currently fails by returning 797.41")
+ d = 3987 * 0.2; p = 2;
+ assertEquals("roundUp ", 797.40, MathX.roundUp(d, p));
}
public void testCeiling() {