]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-5605 revert to mysql client cursor
authorSimon Brandhof <simon.brandhof@sonarsource.com>
Thu, 30 Oct 2014 21:25:24 +0000 (22:25 +0100)
committerSimon Brandhof <simon.brandhof@sonarsource.com>
Thu, 30 Oct 2014 21:25:24 +0000 (22:25 +0100)
sonar-application/src/main/assembly/conf/sonar.properties
sonar-application/src/main/java/org/sonar/application/JdbcSettings.java
sonar-application/src/test/java/org/sonar/application/JdbcSettingsTest.java

index 064e2beafacad27ded1758e677c525936c71c86a..4c720ee9982871a2344d1b77957b02817d9254a1 100644 (file)
@@ -28,7 +28,7 @@
 
 
 #----- MySQL 5.x
-#sonar.jdbc.url=jdbc:mysql://localhost:3306/sonar?useUnicode=true&characterEncoding=utf8&rewriteBatchedStatements=true&useConfigs=maxPerformance&useCursorFetch=true
+#sonar.jdbc.url=jdbc:mysql://localhost:3306/sonar?useUnicode=true&characterEncoding=utf8&rewriteBatchedStatements=true&useConfigs=maxPerformance
 
 
 #----- Oracle 10g/11g
index b2f36dbb6c01d7f58bb599982f9cfa15bbe00216..4a34e55a642fc28df3a92487b005d96a03a88462 100644 (file)
@@ -95,7 +95,6 @@ public class JdbcSettings {
     if (Provider.MYSQL.equals(provider)) {
       checkRequiredParameter(url, "useUnicode=true");
       checkRequiredParameter(url, "characterEncoding=utf8");
-      checkRequiredParameter(url, "useCursorFetch=true");
       checkRecommendedParameter(url, "rewriteBatchedStatements=true");
       checkRecommendedParameter(url, "useConfigs=maxPerformance");
     }
index d6fd2af70e25212c9a13889b6d4d2fa793f9c485..c5f47749e809c52aba210f2d0ea10140e00f122d 100644 (file)
@@ -61,15 +61,13 @@ public class JdbcSettingsTest {
 
   @Test
   public void check_mysql_parameters() throws Exception {
-    Props props = new Props(new Properties());
-
     // minimal -> ok
     settings.checkUrlParameters(JdbcSettings.Provider.MYSQL,
-      "jdbc:mysql://localhost:3306/sonar?useUnicode=true&characterEncoding=utf8&useCursorFetch=true");
+      "jdbc:mysql://localhost:3306/sonar?useUnicode=true&characterEncoding=utf8");
 
     // full -> ok
     settings.checkUrlParameters(JdbcSettings.Provider.MYSQL,
-      "jdbc:mysql://localhost:3306/sonar?useUnicode=true&characterEncoding=utf8&rewriteBatchedStatements=true&useConfigs=maxPerformance&useCursorFetch=true");
+      "jdbc:mysql://localhost:3306/sonar?useUnicode=true&characterEncoding=utf8&rewriteBatchedStatements=true&useConfigs=maxPerformance");
 
     // missing required -> ko
     try {