SONAR-5892 apply feedback

diff --git a/server/sonar-web/src/main/js/apps/issues/templates/issues-workspace-header.hbs b/server/sonar-web/src/main/js/apps/issues/templates/issues-workspace-header.hbs
index dd98ec389b8798876ce35976308cd6c33804b4b6..163280ac9d919fc23ce2ed71fdf9d13b5cb33d17 100644 (file)
--- a/server/sonar-web/src/main/js/apps/issues/templates/issues-workspace-header.hbs
+++ b/server/sonar-web/src/main/js/apps/issues/templates/issues-workspace-header.hbs
@@ -22,7 +22,8 @@
 
     {{else}}
       {{#if state.canBulkChange}}
-        <a class="js-selection icon-checkbox {{#if allSelected}}icon-checkbox-checked{{/if}} {{#if someSelected}}icon-checkbox-checked icon-checkbox-single{{/if}}"></a>
+        <a class="js-selection icon-checkbox {{#if allSelected}}icon-checkbox-checked{{/if}} {{#if someSelected}}icon-checkbox-checked icon-checkbox-single{{/if}}"
+            data-toggle="tooltip" title="{{t 'issues.toggle_selection_tooltip'}}"></a>
       {{else}}
         &nbsp;
       {{/if}}

diff --git a/server/sonar-web/src/main/js/apps/issues/workspace-header-view.js b/server/sonar-web/src/main/js/apps/issues/workspace-header-view.js
index e7b317442b96748189da5a73983e4c43ab8baf0d..c301c40e872c804d132968706c3a0eaf9c4e3745 100644 (file)
--- a/server/sonar-web/src/main/js/apps/issues/workspace-header-view.js
+++ b/server/sonar-web/src/main/js/apps/issues/workspace-header-view.js
@@ -24,6 +24,7 @@ define([
     },
 
     onClose: function () {
+      this._super();
       window.onBulkIssues = this._onBulkIssues;
     },
 

diff --git a/server/sonar-web/src/main/js/components/navigator/workspace-header-view.js b/server/sonar-web/src/main/js/components/navigator/workspace-header-view.js
index bc4296fcb8a13eee9a1ef6a79c5af39264312bfd..524346fa080632a0e2d15e34f9b68db0e06e09cd 100644 (file)
--- a/server/sonar-web/src/main/js/components/navigator/workspace-header-view.js
+++ b/server/sonar-web/src/main/js/components/navigator/workspace-header-view.js
@@ -40,6 +40,18 @@ define(function () {
       this.listenTo(options.app.state, 'change', this.render);
     },
 
+    onRender: function () {
+      this.$('[data-toggle="tooltip"]').tooltip({ container: 'body', placement: 'bottom' });
+    },
+
+    onBeforeRender: function () {
+      this.$('[data-toggle="tooltip"]').tooltip('destroy');
+    },
+
+    onClose: function () {
+      this.$('[data-toggle="tooltip"]').tooltip('destroy');
+    },
+
     onBulkChangeClick: function (e) {
       e.preventDefault();
       this.bulkChange();

diff --git a/sonar-core/src/main/resources/org/sonar/l10n/core.properties b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
index 12b7df60ccadca012c1f55a4aabfb58e25a4456a..249651373f0ec2a613ee93f2a973bddab4277f90 100644 (file)
--- a/sonar-core/src/main/resources/org/sonar/l10n/core.properties
+++ b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
@@ -730,6 +730,7 @@ issues.home.my_filters=My Filters
 issues.home.projects=Projects
 issues.home.authors=Authors
 issues.home.tags=Tags
+issues.toggle_selection_tooltip=(De-)Select all currently visible issues
 
 
 #------------------------------------------------------------------------------