NO-JIRA fixed randomly failing selectRulesByProfile_ready_rules_only test

diff --git a/server/sonar-db-dao/src/testFixtures/java/org/sonar/db/rule/RuleTesting.java b/server/sonar-db-dao/src/testFixtures/java/org/sonar/db/rule/RuleTesting.java
index 59d21db54c2524b639b308099d84fb30ab178a1d..c2a064c6a43016e1b2ecf97b19e7e761477dd4c9 100644 (file)
--- a/server/sonar-db-dao/src/testFixtures/java/org/sonar/db/rule/RuleTesting.java
+++ b/server/sonar-db-dao/src/testFixtures/java/org/sonar/db/rule/RuleTesting.java
@@ -22,6 +22,7 @@ package org.sonar.db.rule;
 import com.google.common.collect.ImmutableSet;
 import java.util.Date;
 import java.util.Set;
+import java.util.concurrent.atomic.AtomicLong;
 import java.util.function.Consumer;
 import javax.annotation.Nullable;
 import org.sonar.api.rule.RuleKey;
@@ -55,6 +56,8 @@ public class RuleTesting {
   public static final RuleKey XOO_X2 = RuleKey.of("xoo", "x2");
   public static final RuleKey XOO_X3 = RuleKey.of("xoo", "x3");
 
+  private static final AtomicLong nextRuleId = new AtomicLong(0);
+
   private static final UuidFactory uuidFactory = UuidFactoryFast.getInstance();
 
   private RuleTesting() {
@@ -219,11 +222,11 @@ public class RuleTesting {
   }
 
   public static RuleKey randomRuleKey() {
-    return RuleKey.of("repo_" + randomAlphanumeric(3), "rule_" + randomAlphanumeric(3));
+    return RuleKey.of("repo_" + getNextUniqueId(), "rule_" + getNextUniqueId());
   }
 
-  public static RuleKey randomRuleKeyOfMaximumLength() {
-    return RuleKey.of(randomAlphabetic(255), randomAlphabetic(200));
+  private static String getNextUniqueId() {
+    return String.format("%010d", nextRuleId.getAndIncrement());
   }
 
   public static Consumer<RuleDto> setRepositoryKey(String repositoryKey) {