DbSession session = dbClient.openSession(false);
try {
Component root = treeRootHolder.getRoot();
- ProcessPersistSnapshot processPersistSnapshot = new ProcessPersistSnapshot(session, reportReader, reportReader.readMetadata().getAnalysisDate());
+ ProcessPersistSnapshot processPersistSnapshot = new ProcessPersistSnapshot(session, reportReader.readMetadata().getAnalysisDate());
processPersistSnapshot.process(root, null);
session.commit();
} finally {
private class ProcessPersistSnapshot {
- private final BatchReportReader reportReader;
private final DbSession dbSession;
private final long analysisDate;
private long projectId;
- public ProcessPersistSnapshot(DbSession dbSession, BatchReportReader reportReader, long analysisDate) {
- this.reportReader = reportReader;
+ public ProcessPersistSnapshot(DbSession dbSession, long analysisDate) {
this.dbSession = dbSession;
this.analysisDate = analysisDate;
}
xml.append("</" + CHARACTERISTIC + ">");
}
- private void processRule(RuleDebt rule, StringBuilder xml) {
+ private static void processRule(RuleDebt rule, StringBuilder xml) {
xml.append("<" + CHARACTERISTIC + ">");
xml.append("<" + REPOSITORY_KEY + ">");
xml.append(StringEscapeUtils.escapeXml(rule.ruleKey().repository()));
}
@CheckForNull
- private RuleDebt createRule(RuleKey ruleKey, Properties properties, ValidationMessages validationMessages) {
+ private static RuleDebt createRule(RuleKey ruleKey, Properties properties, ValidationMessages validationMessages) {
Property function = properties.function();
if (function != null) {
json.endObject();
}
- private void writeDuplications(List<DuplicationsParser.Block> blocks, Map<String, String> refByComponentKey, JsonWriter json) {
+ private static void writeDuplications(List<DuplicationsParser.Block> blocks, Map<String, String> refByComponentKey, JsonWriter json) {
for (DuplicationsParser.Block block : blocks) {
json.beginObject().name("blocks").beginArray();
for (DuplicationsParser.Duplication duplication : block.duplications()) {
controller.done();
}
- private void defineRailsActions(NewController controller) {
+ private static void defineRailsActions(NewController controller) {
defineChangelogAction(controller);
defineAssignAction(controller);
defineAddCommentAction(controller);
return toGroupQueryResult(permissionTemplateDao.selectGroups(query, permissionTemplateId), query);
}
- private UserWithPermissionQueryResult toUserQueryResult(List<UserWithPermissionDto> dtos, int limit) {
+ private static UserWithPermissionQueryResult toUserQueryResult(List<UserWithPermissionDto> dtos, int limit) {
boolean hasMoreResults = false;
if (dtos.size() == limit) {
hasMoreResults = true;
}
}
- private void addLine(List<String> decoratedHtmlLines, String line, int currentLine, @Nullable Integer from, @Nullable Integer to) {
+ private static void addLine(List<String> decoratedHtmlLines, String line, int currentLine, @Nullable Integer from, @Nullable Integer to) {
if (canAddLine(currentLine, from) && !shouldStop(currentLine, to)) {
decoratedHtmlLines.add(line);
}
return finder.find(parseQuery(params));
}
- private GroupMembershipQuery parseQuery(Map<String, Object> params) {
+ private static GroupMembershipQuery parseQuery(Map<String, Object> params) {
GroupMembershipQuery.Builder builder = GroupMembershipQuery.builder();
builder.membership(membership(params));
builder.groupSearch((String) params.get("query"));
}
}
- private long doIndex(BulkIndexer bulk, Iterator<UserDoc> users) {
+ private static long doIndex(BulkIndexer bulk, Iterator<UserDoc> users) {
long maxUpdatedAt = 0L;
bulk.start();
while (users.hasNext()) {
json.endObject().close();
}
- private void writeUser(JsonWriter json, UserDoc user) {
+ private static void writeUser(JsonWriter json, UserDoc user) {
json.name("user").beginObject()
.prop("login", user.login())
.prop("name", user.name())
public class ComponentImplTest {
- private ComponentImpl component = new ComponentImpl(BatchReport.Component.newBuilder().build(), Collections.<Component>emptyList());
-
@Test(expected = NullPointerException.class)
public void constructor_throws_NPE_if_component_arg_is_Null() {
new ComponentImpl(null, null);
@Test(expected = UnsupportedOperationException.class)
public void getUuid_throws_UOE_if_uuid_has_not_been_set_yet() {
+ ComponentImpl component = new ComponentImpl(BatchReport.Component.newBuilder().build(), Collections.<Component>emptyList());
component.getUuid();
}
@Test(expected = UnsupportedOperationException.class)
public void getKey_throws_UOE_if_uuid_has_not_been_set_yet() {
+ ComponentImpl component = new ComponentImpl(BatchReport.Component.newBuilder().build(), Collections.<Component>emptyList());
component.getKey();
}
@Test
public void verify_setUuid() {
String uuid = "toto";
- assertThat(component.setUuid(uuid).getUuid()).isEqualTo(uuid);
+ ComponentImpl component = new ComponentImpl(BatchReport.Component.newBuilder().build(), Collections.<Component>emptyList()).setUuid(uuid);
+ assertThat(component.getUuid()).isEqualTo(uuid);
}
@Test
public void verify_setKey() {
String key = "toto";
- assertThat(component.setKey(key).getKey()).isEqualTo(key);
+ ComponentImpl component = new ComponentImpl(BatchReport.Component.newBuilder().build(), Collections.<Component>emptyList()).setKey(key);
+ assertThat(component.getKey()).isEqualTo(key);
+ }
+
+ @Test
+ public void get_name_from_batch_component() throws Exception {
+ String name = "project";
+ ComponentImpl component = new ComponentImpl(BatchReport.Component.newBuilder().setName(name).build(), Collections.<Component>emptyList());
+ assertThat(component.getName()).isEqualTo(name);
+ }
+
+ @Test
+ public void get_version_from_batch_component() throws Exception {
+ String version = "1.0";
+ ComponentImpl component = new ComponentImpl(BatchReport.Component.newBuilder().setVersion(version).build(), Collections.<Component>emptyList());
+ assertThat(component.getVersion()).isEqualTo(version);
+ }
+
+ @Test
+ public void get_is_unit_test_from_batch_component() throws Exception {
+ ComponentImpl component = new ComponentImpl(BatchReport.Component.newBuilder().setIsTest(true).build(), Collections.<Component>emptyList());
+ assertThat(component.isUnitTest()).isTrue();
}
@Test
}
}
- private void saveIssuesPerRules(DecoratorContext context, RulePriority severity, Map<RulePriority, Multiset<RuleKey>> rulesPerSeverity) {
+ private static void saveIssuesPerRules(DecoratorContext context, RulePriority severity, Map<RulePriority, Multiset<RuleKey>> rulesPerSeverity) {
Metric metric = SeverityUtils.severityToIssueMetric(severity);
Collection<Measure> children = context.getChildrenMeasures(MeasuresFilters.rules(metric));
context.saveMeasure(measure);
}
- private boolean shouldSaveMeasure(DecoratorContext context) {
+ private static boolean shouldSaveMeasure(DecoratorContext context) {
return context.getMeasure(CoreMetrics.TECHNICAL_DEBT) == null;
}
projects / sonarqube.git / commitdiff