Traversing: .not/.filter consistency with non-elements

Fixes gh-2808
Close gh-2809

diff --git a/src/traversing/findFilter.js b/src/traversing/findFilter.js
index ee76a57a7525b511967a7d9355fab21e20900ac0..f3a929e539b23af88dd0a8ade1d257018f2ebb56 100644 (file)
--- a/src/traversing/findFilter.js
+++ b/src/traversing/findFilter.js
@@ -33,7 +33,7 @@ function winnow( elements, qualifier, not ) {
        }
 
        return jQuery.grep( elements, function( elem ) {
-               return ( indexOf.call( qualifier, elem ) > -1 ) !== not;
+               return ( indexOf.call( qualifier, elem ) > -1 ) !== not && elem.nodeType === 1;
        } );
 }
 

diff --git a/test/unit/traversing.js b/test/unit/traversing.js
index 7766fd3cb8aa1123621d5a726ca48b88c7860689..d38d40be5f73406073ddc4ac26c8112c539aa9e3 100644 (file)
--- a/test/unit/traversing.js
+++ b/test/unit/traversing.js
@@ -430,6 +430,17 @@ QUnit.test( "not(jQuery)", function( assert ) {
        assert.deepEqual( jQuery( "p" ).not( jQuery( "#ap, #sndp, .result" ) ).get(), q( "firstp", "en", "sap", "first" ), "not(jQuery)" );
 } );
 
+QUnit.test( "not(Selector) excludes non-element nodes (gh-2808)", function( assert ) {
+       assert.expect( 3 );
+
+       var mixedContents = jQuery( "#nonnodes" ).contents(),
+               childElements = q( "nonnodesElement" );
+
+       assert.deepEqual( mixedContents.not( "*" ).get(), [], "not *" );
+       assert.deepEqual( mixedContents.not( "[id=a],[id=b]" ).get(), childElements, "not [id=a],[id=b]" );
+       assert.deepEqual( mixedContents.not( "[id=a],*,[id=b]" ).get(), [], "not [id=a],*,[id=b]" );
+} );
+
 QUnit.test( "has(Element)", function( assert ) {
        assert.expect( 3 );
        var obj, detached, multipleParent;