]> source.dussan.org Git - poi.git/commitdiff
[bug-65849] file attributes may cause issues on windows
authorPJ Fanning <fanningpj@apache.org>
Wed, 26 Jan 2022 19:40:47 +0000 (19:40 +0000)
committerPJ Fanning <fanningpj@apache.org>
Wed, 26 Jan 2022 19:40:47 +0000 (19:40 +0000)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1897516 13f79535-47bb-0310-9956-ffa450edef68

poi/src/main/java/org/apache/poi/util/DefaultTempFileCreationStrategy.java

index b5ff8afbeba6b992a899d1fa8001db9c85675c36..342bbeb4f5d622f96f88be18b2ae529d95f49598 100644 (file)
@@ -22,11 +22,6 @@ import static org.apache.poi.util.TempFile.JAVA_IO_TMPDIR;
 import java.io.File;
 import java.io.IOException;
 import java.nio.file.Files;
-import java.nio.file.attribute.FileAttribute;
-import java.nio.file.attribute.PosixFilePermission;
-import java.nio.file.attribute.PosixFilePermissions;
-import java.util.HashSet;
-import java.util.Set;
 
 /**
  * Default implementation of the {@link TempFileCreationStrategy} used by {@link TempFile}:
@@ -46,8 +41,6 @@ public class DefaultTempFileCreationStrategy implements TempFileCreationStrategy
     /** To use files.deleteOnExit after clean JVM exit, set the <code>-Dpoi.delete.tmp.files.on.exit</code> JVM property */
     public static final String DELETE_FILES_ON_EXIT = "poi.delete.tmp.files.on.exit";
 
-    private final FileAttribute<Set<PosixFilePermission>> userPermissions;
-
     /** The directory where the temporary files will be created (<code>null</code> to use the default directory). */
     private File dir;
 
@@ -69,10 +62,6 @@ public class DefaultTempFileCreationStrategy implements TempFileCreationStrategy
      */
     public DefaultTempFileCreationStrategy(File dir) {
         this.dir = dir;
-        Set<PosixFilePermission> permissions = new HashSet<>();
-        permissions.add(PosixFilePermission.OWNER_READ);
-        permissions.add(PosixFilePermission.OWNER_WRITE);
-        userPermissions = PosixFilePermissions.asFileAttribute(permissions);
     }
 
     private void createPOIFilesDirectory() throws IOException {
@@ -115,10 +104,7 @@ public class DefaultTempFileCreationStrategy implements TempFileCreationStrategy
         createPOIFilesDirectory();
 
         // Generate a unique new filename
-        HashSet<PosixFilePermission> permissions = new HashSet<>();
-        permissions.add(PosixFilePermission.OWNER_READ);
-        permissions.add(PosixFilePermission.OWNER_WRITE);
-        File newFile = Files.createTempFile(dir.toPath(), prefix, suffix, userPermissions).toFile();
+        File newFile = Files.createTempFile(dir.toPath(), prefix, suffix).toFile();
 
         // Set the delete on exit flag, but only when explicitly disabled
         if (System.getProperty(DELETE_FILES_ON_EXIT) != null) {