]> source.dussan.org Git - poi.git/commitdiff
tidy up code in FontGroupRange
authorPJ Fanning <fanningpj@apache.org>
Sun, 6 Dec 2020 14:10:44 +0000 (14:10 +0000)
committerPJ Fanning <fanningpj@apache.org>
Sun, 6 Dec 2020 14:10:44 +0000 (14:10 +0000)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884152 13f79535-47bb-0310-9956-ffa450edef68

src/java/org/apache/poi/common/usermodel/fonts/FontGroup.java

index 1cfdc3aeca8ec3c2352d0c21284d3f9241f155b8..78065fbffec638c7453208a1a33b4be4e0342a3c 100644 (file)
@@ -17,6 +17,8 @@ limitations under the License.
 
 package org.apache.poi.common.usermodel.fonts;
 
+import org.apache.poi.util.Removal;
+
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
@@ -44,19 +46,29 @@ public enum FontGroup {
 
 
     public static class FontGroupRange {
-        private int len;
-        private FontGroup fontGroup;
+        private final FontGroup fontGroup;
+        private int len = 0;
+
+        FontGroupRange(FontGroup fontGroup) {
+            this.fontGroup = fontGroup;
+        }
+
         public int getLength() {
             return len;
         }
+
         public FontGroup getFontGroup( ) {
             return fontGroup;
         }
+
+        void increaseLength(int len) {
+            this.len += len;
+        }
     }
 
     private static class Range {
-        int upper;
-        FontGroup fontGroup;
+        final int upper;
+        final FontGroup fontGroup;
         Range(int upper, FontGroup fontGroup) {
             this.upper = upper;
             this.fontGroup = fontGroup;
@@ -130,11 +142,10 @@ public enum FontGroup {
             }
 
             if (ttrLast == null || ttrLast.fontGroup != tt) {
-                ttrLast = new FontGroupRange();
-                ttrLast.fontGroup = tt;
+                ttrLast = new FontGroupRange(tt);
                 ttrList.add(ttrLast);
             }
-            ttrLast.len += charCount;
+            ttrLast.increaseLength(charCount);
         }
         return ttrList;
     }