Suppress/eliminate JDK warnings

diff --git a/java/CMakeLists.txt b/java/CMakeLists.txt
index a076d958a6a1315c808704463e8c58423dbb9893..8f698ac5ba60dacb3407094f7034020acbee7d2f 100644 (file)
--- a/java/CMakeLists.txt
+++ b/java/CMakeLists.txt
@@ -7,7 +7,7 @@ endif()
 
 find_package(Java)
 
-set(DEFAULT_JAVACFLAGS "-source 1.5 -target 1.5 -Xlint:all,-serial,-cast,-unchecked,-fallthrough,-dep-ann,-deprecation,-rawtypes")
+set(DEFAULT_JAVACFLAGS "-source 1.6 -target 1.6 -Xlint:all,-serial,-cast,-unchecked,-fallthrough,-dep-ann,-deprecation,-rawtypes")
 set(JAVACFLAGS ${DEFAULT_JAVACFLAGS} CACHE STRING
   "Java compiler flags (Default: ${DEFAULT_JAVACFLAGS})")
 message(STATUS "Java compiler flags = ${JAVACFLAGS}")

diff --git a/java/com/jcraft/jsch/HostKey.java b/java/com/jcraft/jsch/HostKey.java
index 6269469a3b9a4ae4bbac81573780b1cc3140747d..bf7ab28c67a9064e8bb97fbb25f6cc0409815caf 100644 (file)
--- a/java/com/jcraft/jsch/HostKey.java
+++ b/java/com/jcraft/jsch/HostKey.java
@@ -103,7 +103,7 @@ public class HostKey{
   public String getKey(){
     return Util.byte2str(Util.toBase64(key, 0, key.length));
   }
-  public String getFingerPrint(JSch jsch){
+  @SuppressWarnings({"static"}) public String getFingerPrint(JSch jsch){
     HASH hash=null;
     try{
       Class c=Class.forName(jsch.getConfig("md5"));

diff --git a/java/com/jcraft/jsch/KeyPair.java b/java/com/jcraft/jsch/KeyPair.java
index 7c31f15bddaef5445e4151338470b78db5f187df..3eb3c2dcfa2ddefac68bf4962b7eb1df376f3bf0 100644 (file)
--- a/java/com/jcraft/jsch/KeyPair.java
+++ b/java/com/jcraft/jsch/KeyPair.java
@@ -383,7 +383,7 @@ public abstract class KeyPair{
     return j;
   }
 
-  private Random genRandom(){
+  @SuppressWarnings({"static"}) private Random genRandom(){
     if(random==null){
       try{
        Class c=Class.forName(jsch.getConfig("random"));
@@ -394,7 +394,7 @@ public abstract class KeyPair{
     return random;
   }
 
-  private HASH genHash(){
+  @SuppressWarnings({"static"}) private HASH genHash(){
     try{
       Class c=Class.forName(jsch.getConfig("md5"));
       hash=(HASH)(c.newInstance());
@@ -404,7 +404,7 @@ public abstract class KeyPair{
     }
     return hash;
   }
-  private Cipher genCipher(){
+  @SuppressWarnings({"static"}) private Cipher genCipher(){
     try{
       Class c;
       c=Class.forName(jsch.getConfig("3des-cbc"));
@@ -421,7 +421,7 @@ public abstract class KeyPair{
     h(n) <- hash(h(n-1), passphrase, iv);
     key <- (h(0),...,h(n))[0,..,key.length];
   */
-  synchronized byte[] genKey(byte[] passphrase, byte[] iv){
+  @SuppressWarnings({"static"}) synchronized byte[] genKey(byte[] passphrase, byte[] iv){
     if(cipher==null) cipher=genCipher();
     if(hash==null) hash=genHash();
 
@@ -565,7 +565,7 @@ public abstract class KeyPair{
     }
   }
 
-  public static KeyPair load(JSch jsch, byte[] prvkey, byte[] pubkey) throws JSchException{
+  @SuppressWarnings({"static"}) public static KeyPair load(JSch jsch, byte[] prvkey, byte[] pubkey) throws JSchException{
 
     byte[] iv=new byte[8];       // 8
     boolean encrypted=true;
@@ -985,7 +985,7 @@ public abstract class KeyPair{
     "Private-MAC: "
   };
 
-  static KeyPair loadPPK(JSch jsch, byte[] buf) throws JSchException {
+  @SuppressWarnings({"static"}) static KeyPair loadPPK(JSch jsch, byte[] buf) throws JSchException {
     byte[] pubkey = null;
     byte[] prvkey = null;
     int lines = 0;

diff --git a/java/com/jcraft/jsch/KeyPairDSA.java b/java/com/jcraft/jsch/KeyPairDSA.java
index ca5b708c16204b1bbca21bda3651e2164ab4e4a0..1592226995eba95b538d8d6e930322d25a4bd874 100644 (file)
--- a/java/com/jcraft/jsch/KeyPairDSA.java
+++ b/java/com/jcraft/jsch/KeyPairDSA.java
@@ -59,7 +59,7 @@ public class KeyPairDSA extends KeyPair{
       key_size = (new java.math.BigInteger(P_array)).bitLength();
   }
 
-  void generate(int key_size) throws JSchException{
+  @SuppressWarnings({"static"}) void generate(int key_size) throws JSchException{
     this.key_size=key_size;
     try{
       Class c=Class.forName(jsch.getConfig("keypairgen.dsa"));
@@ -247,7 +247,7 @@ public class KeyPairDSA extends KeyPair{
     return key_size;
   }
 
-  public byte[] getSignature(byte[] data){
+  @SuppressWarnings({"static"}) public byte[] getSignature(byte[] data){
     try{      
       Class c=Class.forName((String)jsch.getConfig("signature.dss"));
       SignatureDSA dsa=(SignatureDSA)(c.newInstance());
@@ -267,7 +267,7 @@ public class KeyPairDSA extends KeyPair{
     return null;
   }
 
-  public Signature getVerifier(){
+  @SuppressWarnings({"static"}) public Signature getVerifier(){
     try{      
       Class c=Class.forName((String)jsch.getConfig("signature.dss"));
       SignatureDSA dsa=(SignatureDSA)(c.newInstance());

diff --git a/java/com/jcraft/jsch/KeyPairECDSA.java b/java/com/jcraft/jsch/KeyPairECDSA.java
index aa25a6ebdba2b4e453bf3969fd6bd0a525f1eb8e..55a52ca41e857e4b52bc91a7a84f8b3d1560bcb5 100644 (file)
--- a/java/com/jcraft/jsch/KeyPairECDSA.java
+++ b/java/com/jcraft/jsch/KeyPairECDSA.java
@@ -71,7 +71,7 @@ public class KeyPairECDSA extends KeyPair{
                   (prv_array.length>=48 ? 384 : 256);
   }
 
-  void generate(int key_size) throws JSchException{
+  @SuppressWarnings({"static"}) void generate(int key_size) throws JSchException{
     this.key_size=key_size;
     try{
       Class c=Class.forName(jsch.getConfig("keypairgen.ecdsa"));
@@ -282,7 +282,7 @@ public class KeyPairECDSA extends KeyPair{
     return key_size;
   }
 
-  public byte[] getSignature(byte[] data){
+  @SuppressWarnings({"static"}) public byte[] getSignature(byte[] data){
     try{      
       Class c=Class.forName((String)jsch.getConfig("signature.ecdsa"));
       SignatureECDSA ecdsa=(SignatureECDSA)(c.newInstance());
@@ -303,7 +303,7 @@ public class KeyPairECDSA extends KeyPair{
     return null;
   }
 
-  public Signature getVerifier(){
+  @SuppressWarnings({"static"}) public Signature getVerifier(){
     try{      
       Class c=Class.forName((String)jsch.getConfig("signature.ecdsa"));
       final SignatureECDSA ecdsa=(SignatureECDSA)(c.newInstance());

diff --git a/java/com/jcraft/jsch/KeyPairPKCS8.java b/java/com/jcraft/jsch/KeyPairPKCS8.java
index 47c2a933cf2a62261aade4454a4f950aad192df9..0aafa7171986e397190d043d2c010182e73bacf6 100644 (file)
--- a/java/com/jcraft/jsch/KeyPairPKCS8.java
+++ b/java/com/jcraft/jsch/KeyPairPKCS8.java
@@ -218,7 +218,7 @@ public class KeyPairPKCS8 extends KeyPair {
     return kpair.forSSHAgent();
   }
 
-  public boolean decrypt(byte[] _passphrase){
+  @SuppressWarnings({"static"}) public boolean decrypt(byte[] _passphrase){
     if(!isEncrypted()){
       return true;
     }
@@ -330,7 +330,7 @@ or
     return false;
   }
 
-  Cipher getCipher(byte[] id){
+  @SuppressWarnings({"static"}) Cipher getCipher(byte[] id){
     Cipher cipher=null;
     String name = null;
     try{

diff --git a/java/com/jcraft/jsch/KeyPairRSA.java b/java/com/jcraft/jsch/KeyPairRSA.java
index 4221b75ed7c7eeac9140d0f57231f301821c1919..97b4120322ca80fc174d4e6ac6882bd6bf583d1c 100644 (file)
--- a/java/com/jcraft/jsch/KeyPairRSA.java
+++ b/java/com/jcraft/jsch/KeyPairRSA.java
@@ -61,7 +61,7 @@ public class KeyPairRSA extends KeyPair{
     }
   }
 
-  void generate(int key_size) throws JSchException{
+  @SuppressWarnings({"static"}) void generate(int key_size) throws JSchException{
     this.key_size=key_size;
     try{
       Class c=Class.forName(jsch.getConfig("keypairgen.rsa"));
@@ -316,7 +316,7 @@ public class KeyPairRSA extends KeyPair{
     return key_size;
   }
 
-  public byte[] getSignature(byte[] data){
+  @SuppressWarnings({"static"}) public byte[] getSignature(byte[] data){
     try{      
       Class c=Class.forName((String)jsch.getConfig("signature.rsa"));
       SignatureRSA rsa=(SignatureRSA)(c.newInstance());
@@ -335,7 +335,7 @@ public class KeyPairRSA extends KeyPair{
     return null;
   }
 
-  public Signature getVerifier(){
+  @SuppressWarnings({"static"}) public Signature getVerifier(){
     try{      
       Class c=Class.forName((String)jsch.getConfig("signature.rsa"));
       SignatureRSA rsa=(SignatureRSA)(c.newInstance());

diff --git a/java/com/jcraft/jsch/KnownHosts.java b/java/com/jcraft/jsch/KnownHosts.java
index b86fa25cc3e80fcfaa6fe9f37f84c1f815b31c26..c4e065180dd7944aae4168723970e1256a4f200f 100644 (file)
--- a/java/com/jcraft/jsch/KnownHosts.java
+++ b/java/com/jcraft/jsch/KnownHosts.java
@@ -482,7 +482,7 @@ loop:
     return hosts;
   }
 
-  private synchronized MAC getHMACSHA1(){
+  @SuppressWarnings({"static"}) private synchronized MAC getHMACSHA1(){
     if(hmacsha1==null){
       try{
         Class c=Class.forName(jsch.getConfig("hmac-sha1"));

diff --git a/java/com/jcraft/jsch/Session.java b/java/com/jcraft/jsch/Session.java
index 39e9029aa8d4485339aa80a5593d34b1e904e49e..4da30cb3123ba6af61925e79509f7169f0cc1357 100644 (file)
--- a/java/com/jcraft/jsch/Session.java
+++ b/java/com/jcraft/jsch/Session.java
@@ -2308,7 +2308,7 @@ break;
     }
   }
 
-  public String getConfig(String key){
+  @SuppressWarnings({"static"}) public String getConfig(String key){
     Object foo=null;
     if(config!=null){
       foo=config.get(key);
@@ -2534,7 +2534,7 @@ break;
     catch(Exception e){ return false; }
   }
 
-  private String[] checkSignatures(String sigs){
+  @SuppressWarnings({"static"}) private String[] checkSignatures(String sigs){
     if(sigs==null || sigs.length()==0)
       return null;
 

diff --git a/java/com/tigervnc/rdr/Exception.java b/java/com/tigervnc/rdr/Exception.java
index 7fd75f81247a9c07ecf5a015e5c0d149c10c4fa7..31d75ecd3332177f6d37d2dfbd00a0ca120c0302 100644 (file)
--- a/java/com/tigervnc/rdr/Exception.java
+++ b/java/com/tigervnc/rdr/Exception.java
@@ -25,12 +25,6 @@ public class Exception extends RuntimeException {
   }
 }
 
-class TimedOut extends Exception {
-  public TimedOut() {
-    super("Timed out");
-  }
-}
-
 class FrameException extends Exception {
   public FrameException() {
     super("Frame Exception");

diff --git a/java/com/tigervnc/rdr/TimedOut.java b/java/com/tigervnc/rdr/TimedOut.java
new file mode 100644 (file)
index 0000000..a0230c7
--- /dev/null
+++ b/java/com/tigervnc/rdr/TimedOut.java
@@ -0,0 +1,26 @@
+/* Copyright (C) 2002-2005 RealVNC Ltd.  All Rights Reserved.
+ * Copyright (C) 2012 Brian P. Hinz
+ *
+ * This is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This software is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this software; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301,
+ * USA.
+ */
+
+package com.tigervnc.rdr;
+
+class TimedOut extends Exception {
+  public TimedOut() {
+    super("Timed out");
+  }
+}