Fix for #2463 - OrderedLayout backwards compatibility CSS issue

svn changeset:6609/svn branch:trunk

diff --git a/WebContent/ITMILL/themes/default/orderedlayout/orderedlayout.css b/WebContent/ITMILL/themes/default/orderedlayout/orderedlayout.css
index d7fd10365fe364104ce99e7501965facd6151542..01d9a78c5ce8f82e364734f8302201714d188491 100644 (file)
--- a/WebContent/ITMILL/themes/default/orderedlayout/orderedlayout.css
+++ b/WebContent/ITMILL/themes/default/orderedlayout/orderedlayout.css
@@ -1,29 +1,29 @@
-.i-horizontallayout, .i-verticallayout {
+.i-orderedlayout, .i-horizontallayout, .i-verticallayout {
        overflow: hidden;
 }
 
-.i-horizontallayout-margin-top, .i-verticallayout-margin-top {
+.i-orderedlayout-margin-top, .i-horizontallayout-margin-top, .i-verticallayout-margin-top {
        padding-top: 15px;
 }
 
-.i-horizontallayout-margin-right, .i-verticallayout-margin-right {
+.i-orderedlayout-margin-right, .i-horizontallayout-margin-right, .i-verticallayout-margin-right {
        padding-right: 18px;
 }
 
-.i-horizontallayout-margin-bottom, .i-verticallayout-margin-bottom {
+.i-orderedlayout-margin-bottom, .i-horizontallayout-margin-bottom, .i-verticallayout-margin-bottom {
        padding-bottom: 15px;
 }
 
-.i-horizontallayout-margin-left, .i-verticallayout-margin-left {
+.i-orderedlayout-margin-left, .i-horizontallayout-margin-left, .i-verticallayout-margin-left {
        padding-left: 18px;
 }
 
-.i-horizontallayout-spacing-on, .i-verticallayout-spacing-on {
+.i-orderedlayout-spacing-on, .i-horizontallayout-spacing-on, .i-verticallayout-spacing-on {
        padding-top: 8px;
        padding-left: 8px;
 }
 /** This can be used to define spacing if spacing is off server side */
-.i-horizontallayout-spacing-off, .i-verticallayout-spacing-off {
+.i-orderedlayout-spacing-off, .i-horizontallayout-spacing-off, .i-verticallayout-spacing-off {
        padding-top: 0px;
        padding-left: 0px;
 }

diff --git a/WebContent/ITMILL/themes/default/styles.css b/WebContent/ITMILL/themes/default/styles.css
index 19468d0eea000e0bf4bd10432f77732458c16103..d925d9ad1698a6b41a91c01703fa90bd9c815ecb 100644 (file)
--- a/WebContent/ITMILL/themes/default/styles.css
+++ b/WebContent/ITMILL/themes/default/styles.css
@@ -961,32 +961,32 @@ input.i-modified,
 }
 
 /* ./WebContent/ITMILL/themes/default/orderedlayout/orderedlayout.css */
-.i-horizontallayout, .i-verticallayout {
+.i-orderedlayout, .i-horizontallayout, .i-verticallayout {
        overflow: hidden;
 }
 
-.i-horizontallayout-margin-top, .i-verticallayout-margin-top {
+.i-orderedlayout-margin-top, .i-horizontallayout-margin-top, .i-verticallayout-margin-top {
        padding-top: 15px;
 }
 
-.i-horizontallayout-margin-right, .i-verticallayout-margin-right {
+.i-orderedlayout-margin-right, .i-horizontallayout-margin-right, .i-verticallayout-margin-right {
        padding-right: 18px;
 }
 
-.i-horizontallayout-margin-bottom, .i-verticallayout-margin-bottom {
+.i-orderedlayout-margin-bottom, .i-horizontallayout-margin-bottom, .i-verticallayout-margin-bottom {
        padding-bottom: 15px;
 }
 
-.i-horizontallayout-margin-left, .i-verticallayout-margin-left {
+.i-orderedlayout-margin-left, .i-horizontallayout-margin-left, .i-verticallayout-margin-left {
        padding-left: 18px;
 }
 
-.i-horizontallayout-spacing-on, .i-verticallayout-spacing-on {
+.i-orderedlayout-spacing-on, .i-horizontallayout-spacing-on, .i-verticallayout-spacing-on {
        padding-top: 8px;
        padding-left: 8px;
 }
 /** This can be used to define spacing if spacing is off server side */
-.i-horizontallayout-spacing-off, .i-verticallayout-spacing-off {
+.i-orderedlayout-spacing-off, .i-horizontallayout-spacing-off, .i-verticallayout-spacing-off {
        padding-top: 0px;
        padding-left: 0px;
 }

diff --git a/src/com/itmill/toolkit/tests/layouts/OrderedLayoutCSSCompatibility.java b/src/com/itmill/toolkit/tests/layouts/OrderedLayoutCSSCompatibility.java
new file mode 100644 (file)
index 0000000..5c37903
--- /dev/null
+++ b/src/com/itmill/toolkit/tests/layouts/OrderedLayoutCSSCompatibility.java
@@ -0,0 +1,32 @@
+package com.itmill.toolkit.tests.layouts;
+
+import com.itmill.toolkit.tests.components.TestBase;
+import com.itmill.toolkit.ui.OrderedLayout;
+import com.itmill.toolkit.ui.TextField;
+
+public class OrderedLayoutCSSCompatibility extends TestBase {
+
+    @Override
+    protected String getDescription() {
+        return "This test is to make sure that spacing/margins in OrderedLayout is still backwards compatible";
+    }
+
+    @Override
+    protected Integer getTicketNumber() {
+        return 2463;
+    }
+
+    @Override
+    protected void setup() {
+        OrderedLayout l = new OrderedLayout(
+                OrderedLayout.ORIENTATION_HORIZONTAL);
+        l.setMargin(true);
+        l.setSpacing(true);
+        l.addComponent(new TextField("abc"));
+        l.addComponent(new TextField("def"));
+
+        addComponent(l);
+
+    }
+
+}