Dialog: Work around subpixel issues in dialog resizable test

Switching to checking the size of the content element. We should be
checking the dimensions of the .ui-dialog element, but that currently
fails in Chromium-based browsers. Once we start using box-sizing:
border-box, we should try to revert this change.

Ref #9845

diff --git a/tests/unit/dialog/dialog_test_helpers.js b/tests/unit/dialog/dialog_test_helpers.js
index 64e8dbf6fb896ee6a5b3c3ca4bc75b590829f436..705eb3010be02a91936feb3b944c81c1ccd243d5 100644 (file)
--- a/tests/unit/dialog/dialog_test_helpers.js
+++ b/tests/unit/dialog/dialog_test_helpers.js
@@ -24,17 +24,20 @@ TestHelpers.dialog = {
                actualDY = offsetAfter.top - offsetBefore.top;
                ok( expectedDX - actualDX <= 1 && expectedDY - actualDY <= 1, "dragged[" + expectedDX + ", " + expectedDY + "] " + msg);
        },
+       // TODO switch back to checking the size of the .ui-dialog element (var d)
+       // once we switch to using box-sizing: border-box (#9845) that should work fine
+       // using the element's dimensions to avoid subpixel errors
        shouldResize: function(element, dw, dh, msg) {
                var heightAfter, widthAfter, actual, expected,
                        d = element.dialog("widget"),
                        handle = $(".ui-resizable-se", d),
-                       heightBefore = d.height(),
-                       widthBefore = d.width();
+                       heightBefore = element.height(),
+                       widthBefore = element.width();
 
                TestHelpers.dialog.drag(element, handle, 50, 50);
 
-               heightAfter = d.height();
-               widthAfter = d.width();
+               heightAfter = element.height();
+               widthAfter = element.width();
 
                msg = msg ? msg + "." : "";
                actual = { width: widthAfter, height: heightAfter },