SONAR-3951 Encode "s" url parameter for resources/search service

diff --git a/sonar-ws-client/src/main/java/org/sonar/wsclient/services/ResourceSearchQuery.java b/sonar-ws-client/src/main/java/org/sonar/wsclient/services/ResourceSearchQuery.java
index aae35d9f2e0c0a44e1e744a954d16f604eed95d6..8648524329cabac7fb77ceece02b5d610983e21b 100644 (file)
--- a/sonar-ws-client/src/main/java/org/sonar/wsclient/services/ResourceSearchQuery.java
+++ b/sonar-ws-client/src/main/java/org/sonar/wsclient/services/ResourceSearchQuery.java
@@ -75,9 +75,8 @@ public class ResourceSearchQuery extends Query<ResourceSearchResult> {
   @Override
   public String getUrl() {
     StringBuilder url = new StringBuilder();
-    url.append("/api/resources/search?s=");
-    url.append(text);
-    url.append("&");
+    url.append("/api/resources/search?");
+    appendUrlParameter(url, "s", text);
     if (page > 0) {
       appendUrlParameter(url, "p", page);
     }

diff --git a/sonar-ws-client/src/test/java/org/sonar/wsclient/services/ResourceSearchQueryTest.java b/sonar-ws-client/src/test/java/org/sonar/wsclient/services/ResourceSearchQueryTest.java
index f789d3618192aa97ce84471f270e71efd908d233..717c321c7025db8daf9f937b6b18d9571ddd58c4 100644 (file)
--- a/sonar-ws-client/src/test/java/org/sonar/wsclient/services/ResourceSearchQueryTest.java
+++ b/sonar-ws-client/src/test/java/org/sonar/wsclient/services/ResourceSearchQueryTest.java
@@ -33,6 +33,13 @@ public class ResourceSearchQueryTest extends QueryTestCase {
     assertThat(query.getModelClass().getName(), is(ResourceSearchResult.class.getName()));
   }
 
+  @Test
+  public void test_encode_url_search_param() {
+    ResourceSearchQuery query = ResourceSearchQuery.create("commons logging");
+    assertThat(query.getUrl(), is("/api/resources/search?s=commons+logging&"));
+    assertThat(query.getModelClass().getName(), is(ResourceSearchResult.class.getName()));
+  }
+
   @Test
   public void test_optional_parameters() {
     ResourceSearchQuery query = ResourceSearchQuery.create("commons");