Fix some quality flaws

diff --git a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/widgets/WidgetsConstants.java b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/widgets/WidgetsConstants.java
index 7fab6f3c0201030c44669b0f693f3c97ef9c6c4e..6f44845d316cd51f0fb1856159e2c7b8af8f06e8 100644 (file)
--- a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/widgets/WidgetsConstants.java
+++ b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/widgets/WidgetsConstants.java
@@ -19,8 +19,6 @@
  */
 package org.sonar.plugins.core.widgets;
 
-import org.sonar.api.web.WidgetProperty;
-
 /**
  * Constants shared accross multiple widgets
  */
@@ -28,7 +26,8 @@ interface WidgetsConstants {
 
   /**
    * Widget property option used to filter out all the metrics which keys start with "new_".
-   * @see WidgetProperty#options()
+   *
+   * @see org.sonar.api.web.WidgetProperty#options()
    */
   String FILTER_OUT_NEW_METRICS = "key:^(?!new_).*";
 }

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/profiles/RulesProfile.java b/sonar-plugin-api/src/main/java/org/sonar/api/profiles/RulesProfile.java
index 9b25030aa549c22c5af31740908d9d6e615605a2..afb2104b597fa88e638a65ee8adcce55cb6da53d 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/profiles/RulesProfile.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/profiles/RulesProfile.java
@@ -396,7 +396,6 @@ public class RulesProfile implements Cloneable {
   public Object clone() {
     RulesProfile clone = RulesProfile.create(getName(), getLanguage());
     clone.setDefaultProfile(getDefaultProfile());
-    clone.setProvided(getProvided());
     clone.setParentName(getParentName());
     if (CollectionUtils.isNotEmpty(activeRules)) {
       clone.setActiveRules(new ArrayList<ActiveRule>(CollectionUtils.collect(activeRules, new Transformer() {

diff --git a/sonar-plugin-api/src/test/java/org/sonar/api/utils/command/CommandTest.java b/sonar-plugin-api/src/test/java/org/sonar/api/utils/command/CommandTest.java
index 2ae9c89b4f8efa101487a18406d41d1eb2d9f284..f85fc0e6db1a290d311487b7ee6604c519ab4c02 100644 (file)
--- a/sonar-plugin-api/src/test/java/org/sonar/api/utils/command/CommandTest.java
+++ b/sonar-plugin-api/src/test/java/org/sonar/api/utils/command/CommandTest.java
@@ -92,7 +92,7 @@ public class CommandTest {
     if (SystemUtils.IS_OS_WINDOWS) {
       Command command = Command.create("foo.bat");
       command.setNewShell(true);
-      assertThat(command.toCommandLine()).isEqualTo("cmd /C foo.bat");
+      assertThat(command.toCommandLine()).isEqualTo("cmd /C call foo.bat");
       assertThat(command.isNewShell()).isTrue();
     } else {
       Command command = Command.create("foo.sh");