improve code quality

diff --git a/server/sonar-web/src/main/js/helpers/measures.js b/server/sonar-web/src/main/js/helpers/measures.js
index afd6afb23d83c98bcb004166c8545a643c62bcdd..a7f331e990b8954ec96b3892685da0d49308ec21 100644 (file)
--- a/server/sonar-web/src/main/js/helpers/measures.js
+++ b/server/sonar-web/src/main/js/helpers/measures.js
@@ -20,6 +20,9 @@
 import numeral from 'numeral';
 import { translate, translateWithParameters } from './l10n';
 
+
+const HOURS_IN_DAY = 8;
+
 /**
  * Format a measure value for a given type
  * @param {string|number} value
@@ -285,15 +288,11 @@ function formatDurationShort (isNegative, days, hours, minutes) {
   return translateWithParameters('work_duration.x_minutes', formattedMinutes);
 }
 
-function getHoursInDay () {
-  return 8;
-}
-
 function durationFormatter (value) {
   if (value === 0 || value === '0') {
     return '0';
   }
-  const hoursInDay = getHoursInDay();
+  const hoursInDay = HOURS_IN_DAY;
   const isNegative = value < 0;
   const absValue = Math.abs(value);
   const days = Math.floor(absValue / hoursInDay / 60);
@@ -308,7 +307,7 @@ function shortDurationFormatter (value) {
   if (value === 0 || value === '0') {
     return '0';
   }
-  const hoursInDay = getHoursInDay();
+  const hoursInDay = HOURS_IN_DAY;
   const isNegative = value < 0;
   const absValue = Math.abs(value);
   const days = absValue / hoursInDay / 60;