Do not create a new stack item on every tab change, reuse the existing

by removing its widget

diff --git a/src/com/vaadin/terminal/gwt/client/ui/VAccordion.java b/src/com/vaadin/terminal/gwt/client/ui/VAccordion.java
index 95db3227305cf2921303677c2ee732bfa77f9deb..e225895995084840d5b276487baeefd021cb7c46 100644 (file)
--- a/src/com/vaadin/terminal/gwt/client/ui/VAccordion.java
+++ b/src/com/vaadin/terminal/gwt/client/ui/VAccordion.java
@@ -128,8 +128,7 @@ public class VAccordion extends VTabsheetBase {
             // StackItem
             Widget oldWidget = item.getComponent();
             if (oldWidget != null) {
-                item = new StackItem(tabUidl);
-                insert(item, getElement(), newIndex, true);
+                oldWidget.removeFromParent();
             }
         }
         return item;
@@ -262,7 +261,8 @@ public class VAccordion extends VTabsheetBase {
     }
 
     /**
-     *
+     * A StackItem has always two children, Child 0 is a VCaption, Child 1 is
+     * the actual child widget.
      */
     protected class StackItem extends ComplexPanel implements ClickHandler {