Fix some quality flaws

diff --git a/sonar-core/src/main/java/org/sonar/core/issue/workflow/IssueWorkflow.java b/sonar-core/src/main/java/org/sonar/core/issue/workflow/IssueWorkflow.java
index 5cec83e94b7d28a6f2057ccea1cf585eeb8a660c..e1f03be4c78bbcf5d3ec471437415cf7ba8b2125 100644 (file)
--- a/sonar-core/src/main/java/org/sonar/core/issue/workflow/IssueWorkflow.java
+++ b/sonar-core/src/main/java/org/sonar/core/issue/workflow/IssueWorkflow.java
@@ -153,6 +153,7 @@ public class IssueWorkflow implements BatchComponent, ServerComponent, Startable
 
   @Override
   public void stop() {
+    // nothing to do
   }
 
   public boolean doTransition(DefaultIssue issue, String transitionKey, IssueChangeContext issueChangeContext) {

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/config/Settings.java b/sonar-plugin-api/src/main/java/org/sonar/api/config/Settings.java
index 4c427ebe68419d3c642d1295b8ab4dd8f9ea130e..1a2780b7846b83efbf2d0971ed337f38f15dd39b 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/config/Settings.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/config/Settings.java
@@ -378,14 +378,18 @@ public class Settings implements BatchComponent, ServerComponent {
   }
 
   protected void doOnSetProperty(String key, @Nullable String value) {
+    // can be overridden
   }
 
   protected void doOnRemoveProperty(String key) {
+    // can be overridden
   }
 
   protected void doOnClearProperties() {
+    // can be overridden
   }
 
   protected void doOnGetProperties(String key) {
+    // can be overridden
   }
 }

diff --git a/sonar-server/src/main/java/org/sonar/server/db/migrations/violation/Progress.java b/sonar-server/src/main/java/org/sonar/server/db/migrations/violation/Progress.java
index c21f017bef17d3f38d268dd7b9a6f5cd8850d388..7673ac2621f110adc422d1b7874fccd382fa8cf3 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/db/migrations/violation/Progress.java
+++ b/sonar-server/src/main/java/org/sonar/server/db/migrations/violation/Progress.java
@@ -23,7 +23,6 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 import java.util.TimerTask;
-import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.atomic.AtomicLong;
 
 /**
@@ -58,8 +57,8 @@ class Progress extends TimerTask {
   public void run() {
     long totalIssues = counter.get();
     long durationMinutes = (System.currentTimeMillis() - start) / 60000L;
-    int percents = (int)((100L * totalIssues) / totalViolations);
-    if (totalIssues>0 && durationMinutes > 0) {
+    int percents = (int) ((100L * totalIssues) / totalViolations);
+    if (totalIssues > 0 && durationMinutes > 0) {
       int frequency = (int) (totalIssues / durationMinutes);
       long remaining = (totalViolations - totalIssues) / frequency;
       logger.info(String.format(