SONAR-2706 Should start displaying the 'loading' icon sooner

=> Before initiating the request (I guess the ITs are failing because
   of this)

diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/project_reviews/_review_command_form.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/project_reviews/_review_command_form.html.erb
index 5d356a3fe8231adca32bf26f157b4312cc9594fd..b0dcfa5e799f2771dd40add79f8afddc80fb496f 100644 (file)
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/project_reviews/_review_command_form.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/project_reviews/_review_command_form.html.erb
@@ -7,7 +7,7 @@
                        Review.command_label(@review_command),
                        :url => {:action => 'run_review_command'},
                        :html => {:id => "submit_btn"},
-                       :loading => "$('loading').show();",
+                       :before => "$('loading').show();",
                        :update => 'review' -%>
    
   <%= link_to_remote message('cancel'), :url => {:action => 'show', :id => params[:id]}, :update => 'review' -%>

diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_violation_comment_form.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_violation_comment_form.html.erb
index 755afb57adddb75060aea989bad830cd90d85600..1f8c3c71696871a20603d41f20f671e4b4122381 100644 (file)
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_violation_comment_form.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_violation_comment_form.html.erb
@@ -37,7 +37,7 @@
                          button_label,
                          :url => {:action => 'violation_save_comment'},
                          :html => {:id => "submit_btn"+params[:id]}.merge(@review_command ? {} : {:disabled => "true"}),
-                         :loading => "$('loading-#{params[:id]}').show();",
+                         :before => "$('loading-#{params[:id]}').show();",
                          :update => 'vId'+params[:id] -%>
      
     <%= link_to_function message('cancel'), "cancelViolationAction(#{params[:id]})" -%>