SONAR-5138 Make Coding Rules menu more consistent with other nav menus

diff --git a/sonar-core/src/main/resources/org/sonar/l10n/core.properties b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
index c3417124df2c843452b4b7d1c783bc70bb157510..c2769512a69089dc3cf74b3857e9558c3dbbe71e 100644 (file)
--- a/sonar-core/src/main/resources/org/sonar/l10n/core.properties
+++ b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
@@ -425,6 +425,7 @@ sidebar.tools=Tools
 
 action_plans.page=Action Plans
 action_plans.page.description=Create and administer Action Plans for this project. Action Plans allow you to prioritize and group issues, and to monitor progress on those groups.
+all_rules.page=All Rules
 coding_rules.page=Coding Rules
 global_permissions.page=Global Permissions
 global_permissions.page.description=Grant and revoke permissions to make changes at the global level. These permissions include editing quality profiles, sharing dashboards, and performing global system administration.

diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/layouts/_menu_coding_rules.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/layouts/_menu_coding_rules.html.erb
index 974e748376047f67acb5c7d3a5db85fa12c184f2..138852a8a0b7bdf6a3cd635ceada631bec2df3f9 100644 (file)
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/layouts/_menu_coding_rules.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/layouts/_menu_coding_rules.html.erb
@@ -1,7 +1,7 @@
 <li>
-  <a href="<%= ApplicationController.root_context -%>/coding_rules"
+  <a href="#"
     class="with-icon<%= ' selected' if [ Navigation::SECTION_CODING_RULES, Navigation::SECTION_QUALITY_PROFILES ].include? selected_section -%>"
-    onmouseover="showDropdownMenu('coding-rules-menu'); return false;">
+    onclick="showDropdownMenu('coding-rules-menu'); return false;">
     <span><%= message('coding_rules.page') -%></span>
     <i class="icon-dropdown"></i>
   </a>
@@ -9,9 +9,9 @@
   <div id="coding-rules-menu" class="dropdown-menu" style="max-width: none; display: none;">
     <div>
       <ul>
+        <li><a href="<%= ApplicationController.root_context -%>/coding_rules"><%= message('all_rules.page') -%></a></li>
         <li><a href="<%= ApplicationController.root_context -%>/profiles"><%= message('quality_profiles.page') -%></a></li>
       </ul>
     </div>
   </div>
-
 </li>