relocated method + added TODO

svn changeset:3709/svn branch:trunk

diff --git a/src/com/itmill/toolkit/terminal/gwt/client/ui/ITextArea.java b/src/com/itmill/toolkit/terminal/gwt/client/ui/ITextArea.java
index deb92869154b5771399b38d99f80307ca0a88027..94bccd7bfdb74c68de6744686203577dea4bfeaf 100644 (file)
--- a/src/com/itmill/toolkit/terminal/gwt/client/ui/ITextArea.java
+++ b/src/com/itmill/toolkit/terminal/gwt/client/ui/ITextArea.java
@@ -5,12 +5,16 @@
 package com.itmill.toolkit.terminal.gwt.client.ui;\r
 \r
 import com.google.gwt.user.client.DOM;\r
+import com.google.gwt.user.client.Element;\r
 import com.itmill.toolkit.terminal.gwt.client.ApplicationConnection;\r
 import com.itmill.toolkit.terminal.gwt.client.UIDL;\r
 \r
 /**\r
  * This class represents a multiline textfield (textarea).\r
  * \r
+ * TODO consider replacing this with a RichTextArea based implementation. IE\r
+ * does not support CSS height for textareas in Strict mode :-(\r
+ * \r
  * @author IT Mill Ltd.\r
  * \r
  */\r
@@ -31,4 +35,16 @@ public class ITextArea extends ITextField {
         }\r
     }\r
 \r
+    public void setRows(int rows) {\r
+        setRows(getElement(), rows);\r
+    }\r
+\r
+    private native void setRows(Element e, int r)\r
+    /*-{\r
+    try {\r
+        if(e.tagName.toLowerCase() == "textarea")\r
+                e.rows = r;\r
+    } catch (e) {}\r
+    }-*/;\r
+\r
 }\r

diff --git a/src/com/itmill/toolkit/terminal/gwt/client/ui/ITextField.java b/src/com/itmill/toolkit/terminal/gwt/client/ui/ITextField.java
index 7152d32c0881a7627312bfb91fdeb60077ff5f2a..278011fec0ec218cae468f54d8a1ffbb8aa9af0d 100644 (file)
--- a/src/com/itmill/toolkit/terminal/gwt/client/ui/ITextField.java
+++ b/src/com/itmill/toolkit/terminal/gwt/client/ui/ITextField.java
@@ -86,30 +86,21 @@ public class ITextField extends TextBoxBase implements Paintable,
         setColumns(getElement(), columns);
     }
 
-    public void setRows(int rows) {
-        setRows(getElement(), rows);
-    }
+    private native void setColumns(Element e, int c)
+    /*-{
+    try {
+       switch(e.tagName.toLowerCase()) {
+               case "input":
+                       //e.size = c;
+                       e.style.width = c+"em";
+                       break;
+               case "textarea":
+                       //e.cols = c;
+                       e.style.width = c+"em";
+                       break;
+               default:;
+       }
+    } catch (e) {}
+    }-*/;
 
-    private native void setColumns(Element e, int c) /*-{
-                            try {
-                               switch(e.tagName.toLowerCase()) {
-                                       case "input":
-                                               //e.size = c;
-                                               e.style.width = c+"em";
-                                               break;
-                                       case "textarea":
-                                               //e.cols = c;
-                                               e.style.width = c+"em";
-                                               break;
-                                       default:;
-                               }
-                            } catch (e) {}
-                            }-*/;
-
-    private native void setRows(Element e, int r) /*-{
-                            try {
-                               if(e.tagName.toLowerCase() == "textarea")
-                                       e.rows = r;
-                            } catch (e) {}
-                            }-*/;
 }