Log exceptions when creating share

Because the exceptions don't always contain a useful message for the UI,
but also because in some cases we need to find out what went wrong.

In some setups, a ShareNotFoundException might happen during creation
when we try to re-read the just written share. Usually related to Galera
Cluster where node syncing wait is not enabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>

diff --git a/apps/files_sharing/lib/Controller/ShareAPIController.php b/apps/files_sharing/lib/Controller/ShareAPIController.php
index 2a2e2614811a5cbb5f0f0c6eb9fb68a95cfc9723..f3b107c6de5b117c5673dd1869b3e68368a37c9d 100644 (file)
--- a/apps/files_sharing/lib/Controller/ShareAPIController.php
+++ b/apps/files_sharing/lib/Controller/ShareAPIController.php
@@ -616,9 +616,11 @@ class ShareAPIController extends OCSController {
                try {
                        $share = $this->shareManager->createShare($share);
                } catch (GenericShareException $e) {
+                       \OC::$server->getLogger()->logException($e);
                        $code = $e->getCode() === 0 ? 403 : $e->getCode();
                        throw new OCSException($e->getHint(), $code);
                } catch (\Exception $e) {
+                       \OC::$server->getLogger()->logException($e);
                        throw new OCSForbiddenException($e->getMessage(), $e);
                }