]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-4746 Modify visibility of property key and layout of property name
authorJean-Baptiste Lievremont <jean-baptiste.lievremont@sonarsource.com>
Wed, 9 Oct 2013 08:46:52 +0000 (10:46 +0200)
committerJean-Baptiste Lievremont <jean-baptiste.lievremont@sonarsource.com>
Wed, 9 Oct 2013 10:33:01 +0000 (12:33 +0200)
Move property key below property description
Add some space between properties
Make property name column fluid

sonar-server/src/main/webapp/WEB-INF/app/views/settings/_properties.html.erb
sonar-server/src/main/webapp/stylesheets/style.css

index 843c6b0904f2fe204550671d7b45f51435bea1d0..34912d8c1ffbc2388270def49edf8949f940a4c0 100644 (file)
     <% if @subcategory.isSpecial %>
       <%= render 'special', :url => url_for(:controller => "#{@subcategory.key}_configuration") -%>
     <% else %>
-      <table class="data marginbottom10">
-        <thead>
         <% if @subcategory.key == @category.key && !category_desc(@category).blank? -%>
-          <tr>
-            <td class="categoryDescription" colspan="2"><%= category_desc(@category) -%> </td>
-          </tr>
+          <p class="categoryDescription"><%= category_desc(@category) -%> </p>
         <% end -%>
         <% if @subcategory.key != @category.key && !subcategory_desc(@category, @subcategory).blank? -%>
-          <tr>
-            <td class="categoryDescription" colspan="2"><%= subcategory_desc(@category, @subcategory) -%> </td>
-          </tr>
+          <p class="categoryDescription" colspan="2"><%= subcategory_desc(@category, @subcategory) -%> </p>
         <% end -%>
-        </thead>
+
+      <table class="marginbottom10">
         <tbody>
         <% by_property_index_or_name(@definitions).each do |property| -%>
           <tr class="property" id="block_<%= property.key -%>">
             <th>
-              <h3>
-                <div><%= property_name(property) -%></div>
-                <div class="note"><%= property.key -%></div>
-              </h3>
+              <h3><%= property_name(property) -%></h3>
             </th>
             <td>
               <% value = property_value(property) -%>
@@ -73,6 +65,7 @@
               <% unless desc.blank? %>
                 <p class="marginbottom10"><%= desc -%></p>
               <% end -%>
+              <div class="note"><%= message('key') -%>:&nbsp;<%= property.key -%></div>
             </td>
           </tr>
         <% end -%>
index 720d46045fc4657254bc727e904dad553f7a348b..a7343bb592f7f8bfae111f78ee534408175edaf4 100644 (file)
@@ -2434,17 +2434,18 @@ textarea.width100 {
   margin-bottom: 10px:
 }
 
+.property h3 {
+  float: none;
+  max-width: 20em;
+}
+
 .property > th, .property > td {
   vertical-align: baseline;
-  padding-right: 10px;
-  padding-left: 10px;
-  padding-bottom: 10px;
+  padding: 10px;
 }
 
 .property > th {
   text-align: right;
-  width: 1px;
-  max-width: 380px;
 }
 
 .property table.data {