log failures to read certificates during listing

Signed-off-by: Robin Appelman <robin@icewind.nl>

diff --git a/lib/private/Security/CertificateManager.php b/lib/private/Security/CertificateManager.php
index b9fbdcc9f02d847e5f30b5eb9cae879d76629c8c..3a87b7f1a004edd8f6070bd51c48cd839ef29a62 100644 (file)
--- a/lib/private/Security/CertificateManager.php
+++ b/lib/private/Security/CertificateManager.php
@@ -83,8 +83,14 @@ class CertificateManager implements ICertificateManager {
                while (false !== ($file = readdir($handle))) {
                        if ($file != '.' && $file != '..') {
                                try {
-                                       $result[] = new Certificate($this->view->file_get_contents($path . $file), $file);
+                                       $content = $this->view->file_get_contents($path . $file);
+                                       if ($content !== false) {
+                                               $result[] = new Certificate($content, $file);
+                                       } else {
+                                               $this->logger->error("Failed to read certificate from $path");
+                                       }
                                } catch (\Exception $e) {
+                                       $this->logger->error("Failed to read certificate from $path", ['exception' => $e]);
                                }
                        }
                }