Dialog: Moved the default value for the position.of option inside the _position(...

This should be reverted in jQuery UI 1.9.

diff --git a/tests/unit/dialog/dialog_defaults.js b/tests/unit/dialog/dialog_defaults.js
index 612fd58c89c43f74d6f4d0e05b5a8b509989fad4..7c94d3336817c37966b2940352154ecd054efc91 100644 (file)
--- a/tests/unit/dialog/dialog_defaults.js
+++ b/tests/unit/dialog/dialog_defaults.js
@@ -20,7 +20,6 @@ var dialog_defaults = {
        position: {
                my: 'center',
                at: 'center',
-               of: window,
                collision: 'fit',
                using: $.ui.dialog.prototype.options.position.using
        },

diff --git a/ui/jquery.ui.dialog.js b/ui/jquery.ui.dialog.js
index 81df1d19b3840b944deaf5b8e738936d082dd5d6..c53169b5bbcd069ac3444e497a3bfe4d549a7fab 100644 (file)
--- a/ui/jquery.ui.dialog.js
+++ b/ui/jquery.ui.dialog.js
@@ -57,7 +57,6 @@ $.widget("ui.dialog", {
                position: {
                        my: 'center',
                        at: 'center',
-                       of: window,
                        collision: 'fit',
                        // ensure that the titlebar is never outside the document
                        using: function(pos) {
@@ -528,7 +527,7 @@ $.widget("ui.dialog", {
                this.uiDialog
                        // workaround for jQuery bug #5781 http://dev.jquery.com/ticket/5781
                        .css({ top: 0, left: 0 })
-                       .position(position);
+                       .position($.extend({ of: window }, position));
                if (!isVisible) {
                        this.uiDialog.hide();
                }